From owner-svn-ports-all@freebsd.org Fri Apr 3 08:09:19 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C8B32789CF; Fri, 3 Apr 2020 08:09:19 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48tsz22X2Qz3ydw; Fri, 3 Apr 2020 08:09:18 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 2578812FA2; Fri, 3 Apr 2020 08:09:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 32587EF9EF; Fri, 3 Apr 2020 10:09:07 +0200 (CEST) Date: Fri, 3 Apr 2020 10:09:07 +0200 From: Baptiste Daroussin To: Mathieu Arnold Cc: Fernando =?utf-8?Q?Apestegu=C3=ADa?= , Mateusz Piotrowski <0mp@freebsd.org>, "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, tom@hur.st Subject: Re: svn commit: r530275 - in head/sysutils/checkrestart: . files Message-ID: <20200403080907.lebeoc4ajd5dwanp@ivaldir.net> References: <202004021151.032BpOMI028447@repo.freebsd.org> <20200403074037.vwysv4oj2gdmnerb@aching.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qoamqanmk7vvx6ua" Content-Disposition: inline In-Reply-To: <20200403074037.vwysv4oj2gdmnerb@aching.in.mat.cc> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 08:09:19 -0000 --qoamqanmk7vvx6ua Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 03, 2020 at 09:40:37AM +0200, Mathieu Arnold wrote: > On Thu, Apr 02, 2020 at 07:56:16PM +0200, Fernando Apestegu=EDa wrote: > > On Thu, Apr 2, 2020 at 2:00 PM Mateusz Piotrowski <0mp@freebsd.org> wro= te: > > > > > > Hi, > > > > > > On 4/2/20 1:51 PM, Fernando Apestegu=EDa wrote: > > > > Author: fernape > > > > Date: Thu Apr 2 11:51:24 2020 > > > > New Revision: 530275 > > > > URL: https://svnweb.freebsd.org/changeset/ports/530275 > > > > > > > > Log: > > > > sysutils/checkrestart: Update to 0.5.0 > > > ... > > > > Added: head/sysutils/checkrestart/files/checkrestart.in > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > > +++ head/sysutils/checkrestart/files/checkrestart.in Thu Apr 2 11= :51:24 2020 (r530275) > > > > @@ -0,0 +1,70 @@ > > > > +#!/bin/sh > > > > +# $FreeBSD$ > > > > + > > > > +if [ -r /etc/defaults/periodic.conf ]; then > > > > + . /etc/defaults/periodic.conf > > > > + source_periodic_confs > > > > +fi > > > > + > > > > +: "${daily_checkrestart_enable:=3DNO}" > > > > +: "${daily_checkrestart_weekdays:=3D1234567}" # Days of the week t= o run, Monday=3D1 > > > > +: "${daily_checkrestart_users:=3D}" # User names or IDs = to check > > > > +: "${daily_checkrestart_jails:=3D}" # Jail names or IDs = to check > > > > +: "${daily_checkrestart_procs:=3D}" # Process names or I= Ds to check > > > > + > > > > +checkrestartcmd=3D/usr/local/bin/checkrestart > > > > > > This should probably utilize %%PREFIX%%. > > > > > > > + > > > > +case "${daily_checkrestart_enable}" in > > > > + [Yy][Ee][Ss]) > > > Please use checkyesno from rc.subr(8) instead. > >=20 > > Hi Mateusz, > >=20 > > Thanks for the point. Would you have a look at > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245283? The > > maintainer doesn't see appropriate this last suggestion. Feel free to > > jump in. >=20 > You know, thre reason we have committers and not a script that applies > the patch and commits is so that we can change the submission to better > fit our policies. You do not need the maintainer's approval to change > that. See the penultimate paragraph here: >=20 > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer= =2Ehtml >=20 Actually the propose change is wrong as the submitter states no periodic sc= ripts are using it, for a very good reason, /etc/defauls/periodic.conf already pr= ovide a function for that which handles specific case for periodic: check_yesno_period So yes there should be a change to the port, but the change is to use that function and not include rc.subr. Best regards, Bapt --qoamqanmk7vvx6ua Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl6G7yAACgkQY4mL3PG3 Plqk5RAAodejlgIgZL/6Kq9hZ+5RU67/hJfFkU0fP9bxGZiWBv5Ov3TUAhJhnKG2 IOndpDp+6S8C/9pgxHM+ynRMBeIDG8KZ7iOUkk7pfqXklOQlxq6AnB+2V2wjkb0e eKVAtmbXJLBOvsIElguq4uMvLjRsZ0FkMQKjUtwmXPVcbZ89rOUQmd2CfPfPraUr XwDj8SV+mPY+1R6IsGMVa2lVU6UfGtnhzeg1rhtu+Gg2aiUSTm9B4YIujpSaM9HP 6anoFCV83kYje5qe4vhUeVnqI9fbJUD9glzjEyBpxy2nFprWOK6cSh3xxuIH+yAX ft3eecY2etQxknReBadJRCKg2Km2ZsLxCH7Ogn2X/OpYjXld3JiQG6Xn8msbQiKB 042N7AsgYFRrFbafYurQ5T46j/rS4aMnblsZqxRcU96rar7PemgN1gH1hzwQEF3f uBaVPwYT0CeODEM49gCOeKuz8gKKaBoQjxZuIlE1bpV69PC4g21gxL6N3IXpr+C2 cFaB2XO1llwX6wQyhzlGWCqAFTNn8jRaPgilFF04MM4yJs2TRBZEFf2w6m2mE1TS h6JvmG1vyetyQUN0+XEic6tV517r4mig7+YqlCxjb1tw/3BsSMZqhfcdvmgDBDXB i4VLFrQ7hrolyCv+eE37UphKztxeG1OCWV3i/qCbhHFEOLX/3Cw= =IpxB -----END PGP SIGNATURE----- --qoamqanmk7vvx6ua--