From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 11:10:59 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 03590A9A; Mon, 16 Feb 2015 11:10:59 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C8E5F794; Mon, 16 Feb 2015 11:10:58 +0000 (UTC) Received: from Julian-MBP3.local ([12.199.201.60]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t1GBAoJP099813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Feb 2015 03:10:50 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <54E1D03A.2070904@freebsd.org> Date: Mon, 16 Feb 2015 03:10:50 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Gleb Smirnoff , mav@FreeBSD.org Subject: Re: svn commit: r278640 - head/sys/netgraph References: <201502122220.t1CMKY8t040498@svn.freebsd.org> <20150214000540.GI15484@FreeBSD.org> In-Reply-To: <20150214000540.GI15484@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 11:10:59 -0000 On 2/13/15 4:05 PM, Gleb Smirnoff wrote: > Hi! > > On Thu, Feb 12, 2015 at 10:20:34PM +0000, Gleb Smirnoff wrote: > T> Author: glebius > T> Date: Thu Feb 12 22:20:34 2015 > T> New Revision: 278640 > T> URL: https://svnweb.freebsd.org/changeset/base/278640 > T> > T> Log: > T> Revise default limit for maximum of netgraph data items. > T> With modern internet speeds the limit can be reached even > T> on a single L2TP link. > > Actually any ng_item of data type requires an mbuf to be connected > to it, and thus I suggest to use mbuf limits to drive ng_item limits. > > If we got an item leak with mbufs being properly freed, then we've > got a bug to fix, and any limit won't work in long run time. I never > evidenced such a bug, but there complaints on hitting limit at > traffic bursts. As said, with previous 512 item limit I experienced > that even on a laptop. > > Any objections on removing the limit, guys? maybe derived from it, but not the same number. maybe change the systctl to define the relationship? > > T> Modified: > T> head/sys/netgraph/ng_base.c > T> > T> Modified: head/sys/netgraph/ng_base.c > T> ============================================================================== > T> --- head/sys/netgraph/ng_base.c Thu Feb 12 21:20:28 2015 (r278639) > T> +++ head/sys/netgraph/ng_base.c Thu Feb 12 22:20:34 2015 (r278640) > T> @@ -2952,7 +2952,7 @@ uma_zone_t ng_qzone; > T> uma_zone_t ng_qdzone; > T> static int numthreads = 0; /* number of queue threads */ > T> static int maxalloc = 4096;/* limit the damage of a leak */ > T> -static int maxdata = 512; /* limit the damage of a DoS */ > T> +static int maxdata = 4096; /* limit the damage of a DoS */ > T> > T> SYSCTL_INT(_net_graph, OID_AUTO, threads, CTLFLAG_RDTUN, &numthreads, > T> 0, "Number of queue processing threads"); > T> >