From owner-freebsd-current Mon Jan 21 14:15:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 9108B37B402; Mon, 21 Jan 2002 14:15:34 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0LMFXD44159; Tue, 22 Jan 2002 01:15:33 +0300 (MSK) (envelope-from ache) Date: Tue, 22 Jan 2002 01:15:31 +0300 From: "Andrey A. Chernov" To: markm@freebsd.org, current@freebsd.org Subject: OPIE little speedup patch for review Message-ID: <20020121221530.GA44147@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.24i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG memset() in opiechallenge() really is not needed because it is the very first thing opielookup() does being entered, i.e. look at this: int opielookup FUNCTION((opie, principal), struct opie *opie AND char *principal) { int i; memset(opie, 0, sizeof(struct opie)); ... And then the patch included: --- challenge.c.bak Tue Apr 11 16:52:01 2000 +++ challenge.c Tue Jan 22 01:07:06 2002 @@ -52,8 +52,6 @@ { int rval = -1; - memset(mp, 0, sizeof(*mp)); - rval = opielookup(mp, name); #if DEBUG if (rval) syslog(LOG_DEBUG, "opiechallenge: opielookup(mp, name=%s) returned %d", name, rval); -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message