From owner-svn-src-head@FreeBSD.ORG Wed Sep 3 05:44:18 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23025F57; Wed, 3 Sep 2014 05:44:18 +0000 (UTC) Received: from mail-yk0-x230.google.com (mail-yk0-x230.google.com [IPv6:2607:f8b0:4002:c07::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B01491EC0; Wed, 3 Sep 2014 05:44:17 +0000 (UTC) Received: by mail-yk0-f176.google.com with SMTP id 19so4724509ykq.21 for ; Tue, 02 Sep 2014 22:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=zoSoomAmAxKHQxJp4LZ51syZ/IoKhf4b3AkK+5qY7iE=; b=D3c+pMvfZbfKZTioUTyZ2fGYdKGRFHrvB258xkvKyFVU+gpbAqGAkMMsoIonYocxAB mAd5X96Lxf7MWpfxvKqfrTazTyqoHA4ooNFPCxYiZQMkB2TMWD3ChKEQ57kTk9+/xtPE kTQkPiEevPXKEbANLl2IGl2CZx6x0jrTw1LJzl5dASRjy1JwN+VbvdVkcqSFep/5Vv/D wQN+SqFIvUtc1IJbOHGPYRZbftc2rD+EXTFi+0WM2zGsQMIrySwiPU6rqfBIuRD+r2nB LdBLvRVmLCMY+nIupuOp03cJiIibPcMgva3/brqCTacX/MT5oThczoSsZa+JlOB/OvB3 Z3CQ== MIME-Version: 1.0 X-Received: by 10.236.121.44 with SMTP id q32mr58901462yhh.55.1409723056870; Tue, 02 Sep 2014 22:44:16 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.164.197 with HTTP; Tue, 2 Sep 2014 22:44:16 -0700 (PDT) In-Reply-To: <201409021116.s82BGiXI071065@svn.freebsd.org> References: <201409021116.s82BGiXI071065@svn.freebsd.org> Date: Wed, 3 Sep 2014 07:44:16 +0200 X-Google-Sender-Auth: oNzTjlPMM7c6ACePfweYJOlLjlo Message-ID: Subject: Re: svn commit: r270964 - head/sys/sys From: Antoine Brodin To: Ed Schouten Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 05:44:18 -0000 On Tue, Sep 2, 2014 at 1:16 PM, Ed Schouten wrote: > Author: ed > Date: Tue Sep 2 11:16:44 2014 > New Revision: 270964 > URL: http://svnweb.freebsd.org/changeset/base/270964 > > Log: > Clean up slightly. > > - Remove c++0x hack from that was needed when Clang did > not fully implement C++11. We can now safely test against C++11 to > check whether thread_local is available, like we do for all other > C++11 keywords. > > - Don't use __clang__ to test for thread safety annotation presence. It > turns out we have a proper attribute for this. > > Modified: > head/sys/sys/cdefs.h > > Modified: head/sys/sys/cdefs.h > ============================================================================== > --- head/sys/sys/cdefs.h Tue Sep 2 10:35:04 2014 (r270963) > +++ head/sys/sys/cdefs.h Tue Sep 2 11:16:44 2014 (r270964) > @@ -298,8 +298,7 @@ > #endif > > #if !__has_extension(c_thread_local) > -/* XXX: Change this to test against C++11 when clang in base supports it. */ > -#if /* (defined(__cplusplus) && __cplusplus >= 201103L) || */ \ > +#if (defined(__cplusplus) && __cplusplus >= 201103L) || \ > __has_extension(cxx_thread_local) > #define _Thread_local thread_local > #else Hi, This change may break the lang/gcc port on head: http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p367138_s270990/logs/errors/gcc-4.7.4.log Cheers, Antoine