From owner-freebsd-ports@FreeBSD.ORG Fri Jan 15 18:41:54 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D9E81065676; Fri, 15 Jan 2010 18:41:54 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (113901-app1.sourcehosting.net [72.32.213.11]) by mx1.freebsd.org (Postfix) with ESMTP id 16E158FC16; Fri, 15 Jan 2010 18:41:53 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=cube.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.69 (FreeBSD)) (envelope-from ) id 1NVr7C-000Lhp-TG; Fri, 15 Jan 2010 13:41:52 -0500 Received: from [127.0.0.1] (fireball.entropy.prv [192.168.1.12]) by cube.entropy.prv (Postfix) with ESMTP id CB4A03A18A0B; Fri, 15 Jan 2010 13:41:46 -0500 (EST) Message-ID: <4B50B6DD.6040600@FreeBSD.org> Date: Fri, 15 Jan 2010 13:41:33 -0500 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Torfinn Ingolfsen References: <4B4FB10D.5040905@FreeBSD.org> <20100115001412.138ed882@gumby.homeunix.com> In-Reply-To: X-Enigmail-Version: 0.96.0 OpenPGP: id=1C940290 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.3 (/) Cc: demon@freebsd.org, FreeBSD Ports ML Subject: Re: sysutils/xfce4-netload-plugin - why is it marked as broken on 8? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2010 18:41:54 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Torfinn Ingolfsen wrote: > Hi, > > On Fri, Jan 15, 2010 at 1:14 AM, RW wrote: > >> On Thu, 14 Jan 2010 19:04:29 -0500 >> Greg Larkin wrote: >> >> >>> The CVS commit in question says that the breakage was reported by >>> pointyhat (FreeBSD package building cluster): >>> >> http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/xfce4-netload-plugin/Makefile#rev1.28 >>> In fact, pav@ included the specific compiler error. I wonder if there >>> was possibly a bug in the early 8.0 OS at that time (13 Jun 2009) that >>> caused the build failure. >>> >>> If you are able to build and run successfully under 8.0 now, I suggest >>> filing a PR with a patch to unbreak the port. >> I just tried it and it failed on 8.0 (RELENGE_8_0), the OP is using >> 8-stable. >> > > Well, shouldn't the port only be marked broken for RELENG_8_0 (and perhaps > -CURRENT) then, and not for RELENG_8? > I don't know how to do that, or I would file a PR. Hi Torfinn, There's an explanation of what happened to if_ppp.h here: http://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html This commit log refers to the fact that the value of __FreeBSD_version was bumped to 800045 due to the removal of the if_ppp(4) driver. You can find all of the historical values of that variable here: http://www.freebsd.org/doc/en/books/porters-handbook/freebsd-versions.html In this case, the port Makefile should be patched like so: - --- Makefile.orig 2010-01-15 13:37:50.374330422 -0500 +++ Makefile 2010-01-15 13:38:04.101133409 -0500 @@ -24,7 +24,7 @@ .include - -.if ${OSVERSION} >= 800000 +.if ${OSVERSION} >= 800045 BROKEN= does not compile: error: net/if_ppp.h: No such file or directory .endif A better fix might be to port the code from using if_ppp(4) to the replacement ppp(8), as noted in the commit log. Regards, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/sourcehosting/ - Follow me, follow you -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iD8DBQFLULbd0sRouByUApARAhzAAJ9QWrqCN1N/JRLF9RO4Rr/MBN76dgCfX4DH tBd6gqJctCM0UFPCVi4TRiM= =n8+3 -----END PGP SIGNATURE-----