From owner-cvs-all Sun Aug 5 7:40:47 2001 Delivered-To: cvs-all@freebsd.org Received: from emmi.physik.TU-Berlin.DE (emmi.physik.TU-Berlin.DE [130.149.160.103]) by hub.freebsd.org (Postfix) with ESMTP id 54F7D37B401; Sun, 5 Aug 2001 07:40:41 -0700 (PDT) (envelope-from ibex@emmi.physik.TU-Berlin.DE) Received: (from ibex@localhost) by emmi.physik.TU-Berlin.DE (8.11.4/8.11.3) id f75EeeP86409; Sun, 5 Aug 2001 16:40:40 +0200 (CEST) (envelope-from ibex) Date: Sun, 5 Aug 2001 16:40:40 +0200 From: Dirk Froemberg To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/databases/mysql323-server Makefile Message-ID: <20010805164039.A86152@physik.TU-Berlin.DE> References: <200108051201.f75C1AA97756@freefall.freebsd.org> <20010805102157.B9635@csh.rit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010805102157.B9635@csh.rit.edu>; from jon@csh.rit.edu on Sun, Aug 05, 2001 at 10:21:57AM -0400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi Jon! On Sun, Aug 05, 2001 at 10:21:57AM -0400, Jon Parise wrote: > On Sun, Aug 05, 2001 at 05:01:10AM -0700, Dirk Froemberg wrote: > > > Log: > > Add two new Makefile variables: SKIP_INSTALL_DB, INSTALL_DB_FORCE > > (see Makefile for explanation). > > Maybe I'm just being picky, but wouldn't it be better to name > those more consistently? > > e.g. SKIP_INSTALL_DB, FORCE_INSTALL_DB > INSTALL_DB_SKIP, INSTALL_DB_FORCE Consistency is always good. 8-) But I don't like INSTALL_DB_SKIP and FORCE_INSTALL_DB. I think we should call INSTALL_DB_FORCE SKIP_DNS_CHECK then to be consistent. Regards Dirk -- Dirk Froemberg FreeBSD: The Power to Serve! http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message