From nobody Mon Jul 13 19:40:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gzXq80bk8z6lhJP for ; Mon, 13 Jul 2026 19:40:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gzXq74yMbz3VRh for ; Mon, 13 Jul 2026 19:40:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783971651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oaksAoMYoUg0CQJ+1uQicAUNpjv9V6wkSvRAcqcMh8s=; b=FSO31yXYHv/M71N5JV7abQLamwm2NR78tMVOrGSegdyzpG2geDWoVOxWJ79G43PTVXMj8o kdCE4+dhNW+uYF2pTSNPBiwJLBjrYhLtzWBBj5aSAimikYDjbmcqHz2AKSdwJ9R2B1CuBW NPDprnNysrkfCaM5AF3pPaiMnFWMoTqJXl7LO8a26kxj4K7smp7w6F+3/ud1GAdBGRd/I/ zKCgEtXR0RP4VWO5Pu38LlS0hAyCnxGg/wBwsngSFg5PZOz3NtmHWcf+E+rxQoni0fIdHk WO70qjVxpH3M07PtFzOiBuNP17EuOipD9b6Z5moJY/3bQnFBl3Ir0+UCJWkEOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783971651; a=rsa-sha256; cv=none; b=fdAbEtEQTmFQ12a5MHKnyGui0004YRDDIt66kXh/NJfw7IVGM7TFVbRk9sFTG5JDz9xPGX lm+TBR6qrvjvtkYfSAbVw28meiezDr6s5+TBvPKqDnvvSYnx/TppCnQjVlcGQHINY1jk0u YOMNbGU60Sv+O0Sx5Z23o2/viO+ueYFSeaUMKyqeV8AqOf/ygyvNsW0F2B/kJc0T8tr4pN F8geQFQc2I4c+fGsNiSs88WI0B8aqK22+FWKh5SLwp7na4PhbdM/yo2RQm7h/kJYImbaB4 Uwdv1Psj4z6GDh73I+pjYV0b9i7n7ZwevR0Y/BI3aZFki7hteXjWNKhAJ7RYwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783971651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oaksAoMYoUg0CQJ+1uQicAUNpjv9V6wkSvRAcqcMh8s=; b=CGixrxPMw3z+ZjPkOTazBCvD1+CYAml2Bxt/2OaVH9JrwRUSLGRAeVC85KcpRq4j0ngw5H y++Oz0ZYxPgKvNGRdCT3kNseYb3PSiVfWi3exzWvzWBdtsxQXev9WzU02EKbMC5gOYdDgW zAfqGf5lxk3zP8WinOYOKg1uMIDgW4uezIY1vEfxjBUOLjUF+X5xLOci8+TRK03SZovcb/ kT63lAT7ReUA7D+00MgupPQR16NxHQOd941iXMMypS9IxZTuP8RtSDqCk4g5qC1S+LS62C PqtunJFCQIj0//sY64xukC1NXtIHT+D64BUG9hjHUdCQYDd9GPxdomSm4x1+eQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gzXq73g9dz1BSV for ; Mon, 13 Jul 2026 19:40:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33d8f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 13 Jul 2026 19:40:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 01f165c68103 - main - sched/lapic: remove sched_do_timer_accounting() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 01f165c68103df22cebe26d410c1d4a0e5fae377 Auto-Submitted: auto-generated Date: Mon, 13 Jul 2026 19:40:51 +0000 Message-Id: <6a553f43.33d8f.5524d352@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=01f165c68103df22cebe26d410c1d4a0e5fae377 commit 01f165c68103df22cebe26d410c1d4a0e5fae377 Author: Mitchell Horne AuthorDate: 2026-07-13 19:15:38 +0000 Commit: Mitchell Horne CommitDate: 2026-07-13 19:40:43 +0000 sched/lapic: remove sched_do_timer_accounting() The check is always true, especially after the removal of hlt_cpus_mask from sched_4bsd. Reviewed by: olce, kib MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58159 --- sys/kern/sched_4bsd.c | 7 ------- sys/kern/sched_shim.c | 1 - sys/kern/sched_ule.c | 7 ------- sys/sys/sched.h | 3 --- sys/x86/x86/local_apic.c | 3 --- 5 files changed, 21 deletions(-) diff --git a/sys/kern/sched_4bsd.c b/sys/kern/sched_4bsd.c index 043a4d291c9f..53e32026029d 100644 --- a/sys/kern/sched_4bsd.c +++ b/sys/kern/sched_4bsd.c @@ -1822,12 +1822,6 @@ sched_4bsd_affinity(struct thread *td) #endif } -static bool -sched_4bsd_do_timer_accounting(void) -{ - return (true); -} - static int sched_4bsd_find_l2_neighbor(int cpu) { @@ -1876,7 +1870,6 @@ struct sched_instance sched_4bsd_instance = { SLOT(sizeof_thread), SLOT(tdname), SLOT(clear_tdname), - SLOT(do_timer_accounting), SLOT(find_l2_neighbor), SLOT(init), SLOT(init_ap), diff --git a/sys/kern/sched_shim.c b/sys/kern/sched_shim.c index 6f0473084704..2ff97a5774e1 100644 --- a/sys/kern/sched_shim.c +++ b/sys/kern/sched_shim.c @@ -85,7 +85,6 @@ DEFINE_SHIM0(sizeof_proc, int, sched_sizeof_proc) DEFINE_SHIM0(sizeof_thread, int, sched_sizeof_thread) DEFINE_SHIM1(tdname, char *, sched_tdname, struct thread *, td) DEFINE_SHIM1(clear_tdname, void, sched_clear_tdname, struct thread *, td) -DEFINE_SHIM0(do_timer_accounting, bool, sched_do_timer_accounting) DEFINE_SHIM1(find_l2_neighbor, int, sched_find_l2_neighbor, int, cpu) DEFINE_SHIM0(init_ap, void, schedinit_ap) diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index eb00072b5012..cf0baabfda86 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -3321,12 +3321,6 @@ sched_ule_schedcpu(void) { } -static bool -sched_ule_do_timer_accounting(void) -{ - return (true); -} - #ifdef SMP static int sched_ule_find_child_with_core(int cpu, struct cpu_group *grp) @@ -3436,7 +3430,6 @@ struct sched_instance sched_ule_instance = { SLOT(sizeof_thread), SLOT(tdname), SLOT(clear_tdname), - SLOT(do_timer_accounting), SLOT(find_l2_neighbor), SLOT(init), SLOT(init_ap), diff --git a/sys/sys/sched.h b/sys/sys/sched.h index c7b7b849947c..a7519f988762 100644 --- a/sys/sys/sched.h +++ b/sys/sys/sched.h @@ -263,8 +263,6 @@ void schedinit(void); */ void schedinit_ap(void); -bool sched_do_timer_accounting(void); - /* * Find an L2 neighbor of the given CPU or return -1 if none found. This * does not distinguish among multiple L2 neighbors if the given CPU has @@ -313,7 +311,6 @@ struct sched_instance { int (*sizeof_thread)(void); char *(*tdname)(struct thread *td); void (*clear_tdname)(struct thread *td); - bool (*do_timer_accounting)(void); int (*find_l2_neighbor)(int cpuid); void (*init)(void); void (*init_ap)(void); diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c index aceb9a229c4f..daac99fad753 100644 --- a/sys/x86/x86/local_apic.c +++ b/sys/x86/x86/local_apic.c @@ -1478,9 +1478,6 @@ lapic_handle_timer(struct trapframe *frame) kmsan_mark(frame, sizeof(*frame), KMSAN_STATE_INITED); trap_check_kstack(); - if (!sched_do_timer_accounting()) - return; - /* Look up our local APIC structure for the tick counters. */ la = &lapics[PCPU_GET(apic_id)]; (*la->la_timer_count)++;