From owner-cvs-src@FreeBSD.ORG Wed Mar 26 18:14:41 2008 Return-Path: <owner-cvs-src@FreeBSD.ORG> Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEFF6106564A; Wed, 26 Mar 2008 18:14:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 365C58FC2A; Wed, 26 Mar 2008 18:14:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 236821806-1834499 for multiple; Wed, 26 Mar 2008 14:12:45 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m2QIE8GS091083; Wed, 26 Mar 2008 14:14:08 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin <jhb@freebsd.org> To: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> Date: Wed, 26 Mar 2008 14:07:18 -0400 User-Agent: KMail/1.9.7 References: <510.33130.qm@web33708.mail.mud.yahoo.com> In-Reply-To: <510.33130.qm@web33708.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803261407.18304.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 26 Mar 2008 14:14:08 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/6397/Wed Mar 26 12:06:49 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-src> List-Post: <mailto:cvs-src@freebsd.org> List-Help: <mailto:cvs-src-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>, <mailto:cvs-src-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 26 Mar 2008 18:14:41 -0000 On Wednesday 26 March 2008 01:56:04 pm Abdullah Ibn Hamad Al-Marri wrote: > ----- Original Message ---- > > From: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> > > To: John Baldwin <jhb@FreeBSD.org>; src-committers@FreeBSD.org; cvs-src@FreeBSD.org > > Sent: Friday, March 14, 2008 3:45:01 PM > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c > > > > ----- Original Message ---- > > > From: John Baldwin > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > > Sent: Tuesday, March 11, 2008 1:00:36 AM > > > Subject: cvs commit: src/sys/i386/cpufreq est.c > > > > > > jhb 2008-03-10 22:00:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/cpufreq est.c > > > Log: > > > - Don't execute cpuid to fetch the features. We already have the features > > > present in cpu_feature2. Also, use CPUID2_EST rather than a magic > > > number. > > > - Don't free the ACPI settings list in detach if we are going to fail the > > > request. Otherwise an attempt to kldunload est would free the array > > > but the driver would keep trying to use it. > > > > > > MFC after: 1 week > > > > > > Revision Changes Path > > > 1.14 +5 -5 src/sys/i386/cpufreq/est.c > > > > Hello John > > > > Could you please MFC it to RELENG_7 now? :) > > > > > > -- > > Regards, > > > > -Abdullah Ibn Hamad Al-Marri > > Arab Portal > > http://www.WeArab.Net/ > > John, > > This is C2Q CPU Q6600. > > Upgraded today with RELENG_7. Your CPU needs the est_msr.patch, though it is odd ACPI isn't providing the table in your case. You can find it at http://www.freebsd.org/~jhb/patches/est_msr.patch -- John Baldwin