Date: Wed, 26 Mar 2008 14:07:18 -0400 From: John Baldwin <jhb@freebsd.org> To: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> Cc: cvs-src@freebsd.org, src-committers@freebsd.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c Message-ID: <200803261407.18304.jhb@freebsd.org> In-Reply-To: <510.33130.qm@web33708.mail.mud.yahoo.com> References: <510.33130.qm@web33708.mail.mud.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 26 March 2008 01:56:04 pm Abdullah Ibn Hamad Al-Marri wrote: > ----- Original Message ---- > > From: Abdullah Ibn Hamad Al-Marri <wearabnet@yahoo.ca> > > To: John Baldwin <jhb@FreeBSD.org>; src-committers@FreeBSD.org; cvs-src@FreeBSD.org > > Sent: Friday, March 14, 2008 3:45:01 PM > > Subject: Re: cvs commit: src/sys/i386/cpufreq est.c > > > > ----- Original Message ---- > > > From: John Baldwin > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > > Sent: Tuesday, March 11, 2008 1:00:36 AM > > > Subject: cvs commit: src/sys/i386/cpufreq est.c > > > > > > jhb 2008-03-10 22:00:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/cpufreq est.c > > > Log: > > > - Don't execute cpuid to fetch the features. We already have the features > > > present in cpu_feature2. Also, use CPUID2_EST rather than a magic > > > number. > > > - Don't free the ACPI settings list in detach if we are going to fail the > > > request. Otherwise an attempt to kldunload est would free the array > > > but the driver would keep trying to use it. > > > > > > MFC after: 1 week > > > > > > Revision Changes Path > > > 1.14 +5 -5 src/sys/i386/cpufreq/est.c > > > > Hello John > > > > Could you please MFC it to RELENG_7 now? :) > > > > > > -- > > Regards, > > > > -Abdullah Ibn Hamad Al-Marri > > Arab Portal > > http://www.WeArab.Net/ > > John, > > This is C2Q CPU Q6600. > > Upgraded today with RELENG_7. Your CPU needs the est_msr.patch, though it is odd ACPI isn't providing the table in your case. You can find it at http://www.freebsd.org/~jhb/patches/est_msr.patch -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803261407.18304.jhb>