From owner-freebsd-stable Sun Jul 28 10:48: 2 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC6B237B400 for ; Sun, 28 Jul 2002 10:47:54 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F5DD43E42 for ; Sun, 28 Jul 2002 10:47:51 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g6SHlTk30647; Sun, 28 Jul 2002 20:47:29 +0300 (EEST) (envelope-from ru) Date: Sun, 28 Jul 2002 20:47:29 +0300 From: Ruslan Ermilov To: cyrille.lefevre@laposte.net, freebsd-stable@FreeBSD.ORG Subject: Re: buildworld objdir moved! (was Re: sys/boot) Message-ID: <20020728174729.GB28493@sunbay.com> References: <20020727145030.GA20412@gits.dyndns.org> <20020727151708.GA30397@gits.dyndns.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gatW/ieO32f1wygP" Content-Disposition: inline In-Reply-To: <20020727151708.GA30397@gits.dyndns.org> User-Agent: Mutt/1.3.99i Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 27, 2002 at 05:17:08PM +0200, Cyrille Lefevre wrote: > On Sat, Jul 27, 2002 at 04:50:30PM +0200, Cyrille Lefevre wrote: > > I'm running -stable and I encounter the following problem : > >=20 > > # make buildworld > > ... > > =3D=3D=3D> sys/boot/buildworld > > cd: can't cd to /disk2/freebsd/stable/src/sys/boot/buildworld > > *** Error code 2 >=20 > found it! this is due by recent changes in src/Makefile.inc1. >=20 > TARGET is set using ?=3D and this is a problem when this variable > already exists in the environment as I do through the Makefile > I use to fetch/update/build/install/configure everything. >=20 TARGET was set like this in RELENG_4 since an least revision 1.141.2.40, and the recent "problem" is that MAKEOBJDIRPREFIX is now set based on TARGET instead of TARGET_ARCH, to make it possible to cross-build/release pc98 on i386. > here is the log before w/ the following patch : > -------------------------------------------------------------- > >>> Rebuilding the temporary build tree > -------------------------------------------------------------- > # XXX - These two can depend on any header file. > rm -f /usr/obj/buildworld/disk2/freebsd/stable/src/usr.bin/kdump/ioctl.c > rm -f /usr/obj/buildworld/disk2/freebsd/stable/src/usr.bin/truss/ioctl.c > ^^^^^^^^^^ oops! >=20 > and the log w/ it : > -------------------------------------------------------------- > >>> Rebuilding the temporary build tree > -------------------------------------------------------------- > # XXX - These two can depend on any header file. > rm -f /usr/obj/disk2/freebsd/stable/src/usr.bin/kdump/ioctl.c > rm -f /usr/obj/disk2/freebsd/stable/src/usr.bin/truss/ioctl.c >=20 > Index: /usr/src/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/Makefile.inc1,v > retrieving revision 1.141.2.54 > diff -u -r1.141.2.54 Makefile.inc1 > --- /usr/src/Makefile.inc1 25 Jul 2002 09:33:13 -0000 1.141.2.54 > +++ /usr/src/Makefile.inc1 27 Jul 2002 15:04:17 -0000 > @@ -126,9 +126,12 @@ > MAKEOBJDIRPREFIX?=3D /usr/obj > TARGET_ARCH?=3D ${MACHINE_ARCH} > .if ${TARGET_ARCH} =3D=3D ${MACHINE_ARCH} > -TARGET?=3D ${MACHINE} > +TARGET=3D ${MACHINE} > .else > -TARGET?=3D ${TARGET_ARCH} > +TARGET=3D ${TARGET_ARCH} > +.endif > +.if defined(TARGET_OVERRIDE) > +TARGET=3D ${TARGET_OVERRIDE} > .endif > .if make(buildworld) > BUILD_ARCH!=3D sysctl -n hw.machine_arch >=20 No thanks, please fix your scripts instead. :-) > PS : the previous patch submitted still apply. >=20 I will address this later, when we finished our makefile.style(7). The following makefiles also have this SUBDIR assignment problem: gnu/lib/libregex/Makefile gnu/usr.bin/binutils/as/Makefile gnu/usr.bin/diff/Makefile gnu/usr.bin/grep/Makefile gnu/usr.bin/send-pr/Makefile lib/libpam/Makefile sys/boot/Makefile sys/modules/lomac/Makefile tools/regression/geom/Makefile tools/regression/geom/Test/Makefile usr.bin/bzip2/Makefile Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --gatW/ieO32f1wygP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9RC4xUkv4P6juNwoRAi9sAJ0XnKG9Gpy8YS0xsYJQ5mVfiEY+vACfUJRP 4tJXW5C+AlhfBj3GNnM8uHs= =UfP/ -----END PGP SIGNATURE----- --gatW/ieO32f1wygP-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message