From owner-freebsd-security Sun Nov 12 10:04:06 1995 Return-Path: owner-security Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id KAA17191 for security-outgoing; Sun, 12 Nov 1995 10:04:06 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id KAA17186 for ; Sun, 12 Nov 1995 10:04:04 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id KAA02328; Sun, 12 Nov 1995 10:04:03 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id KAA02195; Sun, 12 Nov 1995 10:03:10 -0800 Message-Id: <199511121803.KAA02195@corbin.Root.COM> To: ache@astral.msk.su cc: Peter Wemm , CVS-commiters@freefall.freebsd.org, security@freebsd.org Subject: Re: cvs commit: CVSROOT log_accum.pl In-reply-to: Your message of "Sun, 12 Nov 95 16:30:08 +0300." From: David Greenman Reply-To: davidg@Root.COM Date: Sun, 12 Nov 1995 10:03:10 -0800 Sender: owner-security@freebsd.org Precedence: bulk >In message > Peter Wemm writes: > >>I'm running a variant of what you proposed in my kernel at the moment.. >> if (!SESS_LEADER(p)) >> printf("setlogin called from a non session leader, pid %d\n", p->p_pid); > >>I do not doubt that your fix is a "good thing" and will be required sooner >>or later, I just want to make sure we are not going to to have a hundred >>bug reports "xdm doesn't work any more" or some other program that we're >>not aware of yet. > >Peter, do you have any progress in this issue for now? >Maybe it is time to commit my fix to -current? If we decide to change setlogin() so that it only works for session leaders, then I'd prefer that we leave out the printf(). If you want to add that to your own sources, fine, but I prefer to keep console noise minimized to important failures. -DG