From owner-svn-src-head@freebsd.org Tue Jul 14 13:42:26 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE79C363360 for ; Tue, 14 Jul 2020 13:42:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5hXK4j1rz3SP0 for ; Tue, 14 Jul 2020 13:42:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf31.google.com with SMTP id el4so7442629qvb.13 for ; Tue, 14 Jul 2020 06:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y9TuZ6+yUpvdQ/7/GS6Om8Ywn1NnO9xGJIZBPjp2eo0=; b=t+LBRUURYoDs0Kp+VwKRuxjNF4AqhTAGkX6A9A7f0mXHhCKsuvnI80+oMyu68lYho6 Gz0XHB+EFG72jkbgYq7AsFaAgQGXJetMUhbq9gDCfqGXT+A9x1Bu1bXZ0YCcXBXU0LU7 gHY4flcsHZLntL0a8amPtvzv8pxkNgsPaaQbMZgTtVPDWtPIYJVrR7NXKROIAH6/9SwN F/+0qhiIsLACvVo+A//fYZhjhqMtCJM+Tga832EeYeh9l9wsHvDmFDrnlyglnDuDgrGY uXMbrcNStnfXf9bNvd84amJPQe3ff8KSBwYI97n+SVEK4T12uZYqWFUW9Vd0gEhJHa/U 0bfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y9TuZ6+yUpvdQ/7/GS6Om8Ywn1NnO9xGJIZBPjp2eo0=; b=pX7XV9s2eMUpB/x4f2PbDbze7+goTUWE+gKDD9h0paZ/glmOj3v1wUPrAWZm71LaUF tcLj1NoQqgFI+iiR5dSe6vMnxV61vC7/RWb/WyaT4Cxy3DdsJ8nBBp2OIJJt/UE8hUg3 1iLVJHTcmYp1QyDNect8ZlL3fiOIzHGWykLwMIYA6vdzUOsqRnVTzUsjPOy5rMyQCMHD +C64Kk/MrlDizzurQ6soNr9CUrqMIAcyWvaoGdUeQp1y1EhJYlp1727AjCBlchGTgSAn FR0OY4ar7Q39PU3QUItExt3O+8/vBgG88PkufDdbJz3Ptdc084upukdZmaTKRjShIjc6 8mSA== X-Gm-Message-State: AOAM532Qwa2GBa1DO5dT2jGFzW80AXfhHhfdUs8OSu0RKHZLZCltogkK O12zf+p3KR+ipYJ8UIPt8jdovlVxv3rb6t/v2xyR7g== X-Google-Smtp-Source: ABdhPJyYqtgBPpbdYi+7PhylZpYCswKjOg+nqTxxRBikzSc2DLJYPbihiMD6Pr/mVkE73hYSWat9aDsY5gKyM0FL+V4= X-Received: by 2002:a05:6214:d4d:: with SMTP id 13mr4519395qvr.22.1594734144491; Tue, 14 Jul 2020 06:42:24 -0700 (PDT) MIME-Version: 1.0 References: <202007140502.06E52IZn022859@repo.freebsd.org> In-Reply-To: <202007140502.06E52IZn022859@repo.freebsd.org> From: Warner Losh Date: Tue, 14 Jul 2020 07:42:12 -0600 Message-ID: Subject: Re: svn commit: r363172 - head/contrib/bc/src To: Adrian Chadd Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4B5hXK4j1rz3SP0 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=t+LBRUUR; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f31) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.74 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.65)[-0.652]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.94)[-0.941]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.14)[-0.144]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f31:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 13:42:26 -0000 Did you intend to commit to contrib software that has an active upstream? This is going to cause conflicts in the future. Maybe you can submit it to the new upstream instead? Warner On Mon, Jul 13, 2020 at 11:02 PM Adrian Chadd wrote: > Author: adrian > Date: Tue Jul 14 05:02:18 2020 > New Revision: 363172 > URL: https://svnweb.freebsd.org/changeset/base/363172 > > Log: > [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. > > I guess this didn't like the case statements.. ? But this does quieten > the compiler error. > > Modified: > head/contrib/bc/src/program.c > > Modified: head/contrib/bc/src/program.c > > ============================================================================== > --- head/contrib/bc/src/program.c Tue Jul 14 05:00:08 2020 > (r363171) > +++ head/contrib/bc/src/program.c Tue Jul 14 05:02:18 2020 > (r363172) > @@ -180,7 +180,7 @@ static inline BcVec* bc_program_vec(const BcProgram *p > > static BcNum* bc_program_num(BcProgram *p, BcResult *r) { > > - BcNum *n; > + BcNum *n = NULL; > > switch (r->t) { > >