From owner-svn-src-all@FreeBSD.ORG Sun Jan 15 23:34:46 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75B5F106564A for ; Sun, 15 Jan 2012 23:34:46 +0000 (UTC) (envelope-from bounces+73574-8822-svn-src-all=freebsd.org@sendgrid.me) Received: from o7.shared.sendgrid.net (o7.shared.sendgrid.net [74.63.235.40]) by mx1.freebsd.org (Postfix) with SMTP id 297F48FC16 for ; Sun, 15 Jan 2012 23:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=d09sZu+YY0b9aypjqRtX5DlEIN8=; b=Dry3NIpA52DaeIWXRAo9/W5Kq+YD kG2qZjk9QS2POGh4Mlust5S43a089ff0M2AUzGuDSFquzvBiTPFMwE991iQESZwz TMTReigOis/nA+AvBOlMlUYaTwtDkIVa89fLu7Jc0LwGSij7g07lIIq7NS9W1a+V nTgu2LdrDumpWTU= Received: by 10.8.49.76 with SMTP id mf36.19239.4F1362951 Sun, 15 Jan 2012 17:34:45 -0600 (CST) Received: from mail.tarsnap.com (unknown [10.9.180.5]) by mi2 (SG) with ESMTP id 4f136294.268d.206499f for ; Sun, 15 Jan 2012 17:34:44 -0600 (CST) Received: (qmail 56323 invoked from network); 15 Jan 2012 23:33:02 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 15 Jan 2012 23:33:02 -0000 Received: (qmail 75936 invoked from network); 15 Jan 2012 23:32:43 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 15 Jan 2012 23:32:43 -0000 Message-ID: <4F13621B.1060203@freebsd.org> Date: Sun, 15 Jan 2012 15:32:43 -0800 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111112 Thunderbird/8.0 MIME-Version: 1.0 To: John Baldwin References: <201201150709.q0F79Iif067938@svn.freebsd.org> <4F136109.9050004@FreeBSD.org> In-Reply-To: <4F136109.9050004@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PH2D7L1xHtixkNMBk+k0zokFoZzwcwv397JkFA5bnNR+RWoCdlWQUXyBlViKrQF2iyVdMICZlzCF4ic/7DNaY/NrwJq1oZXpdJJ/l8q1mPTp9LXBe7++Vb6lB0ikIiN5c0= X-SendGrid-Contentd-ID: {"test_id":1326670485} Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler Subject: Re: svn commit: r230125 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 23:34:46 -0000 On 01/15/12 15:28, John Baldwin wrote: > On 1/15/12 2:09 AM, Eitan Adler wrote: >> Log: >> - Fix undefined behavior when device_get_name is null >> - Make error message more informative > > The in-kernel printf(9) always prints "(null)" for %s when the pointer is NULL, > so that wasn't undefined behavior. Printing out the driver name is a useful > change, but the "(unknown)" bits are just noise as it isn't clear that > "(unknown)" is substantially better than "(null)". I think the change from "(null)" to "(unknown)" is useful, since when I see "(null)" printed my immediate thought is "looks like there's a bug I need to track down here". -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid