From owner-freebsd-stable@freebsd.org Tue Feb 12 22:51:58 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D33014D60EA; Tue, 12 Feb 2019 22:51:58 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 429EF87B97; Tue, 12 Feb 2019 22:51:56 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [82.47.240.30] (helo=foula.drayhouse.twisted.org.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1gtgu9-0008dR-N2; Tue, 12 Feb 2019 22:51:53 +0000 Subject: Re: Networking panic on 12 - found the cause To: Kristof Provost , Eric van Gyzen Cc: "Andrey V. Elsukov" , freebsd-stable@freebsd.org, freebsd-current References: <4a350f47-eaca-5aca-9268-bf7a6618e71c@yandex.ru> <0a0f2668-19f7-ad62-dff4-e2997e57ea5c@vangyzen.net> <20190212201330.GK8450@vega.codepro.be> From: Pete French Message-ID: <50301a70-9c2e-b340-100c-cd1e6429c134@ingresso.co.uk> Date: Tue, 12 Feb 2019 22:52:07 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:65.0) Gecko/20100101 Thunderbird/65.0 MIME-Version: 1.0 In-Reply-To: <20190212201330.GK8450@vega.codepro.be> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 429EF87B97 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=ingresso.co.uk; spf=pass (mx1.freebsd.org: domain of petefrench@ingresso.co.uk designates 2a02:b90:3002:411::3 as permitted sender) smtp.mailfrom=petefrench@ingresso.co.uk X-Spamd-Result: default: False [4.27 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a02:b90:3002:411::3]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-0.02)[country: GB(-0.09)]; RDNS_NONE(1.00)[]; NEURAL_SPAM_MEDIUM(0.35)[0.348,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.45)[0.453,0]; MX_GOOD(-0.01)[cached: us-smtp-inbound-1.mimecast.com]; DMARC_POLICY_ALLOW(-0.50)[ingresso.co.uk,none]; NEURAL_SPAM_LONG(0.80)[0.801,0]; RECEIVED_SPAMHAUS_PBL(0.00)[30.240.47.82.zen.spamhaus.org : 127.0.0.11]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[yandex.ru]; ASN(0.00)[asn:16082, ipnet:2a02:b90::/32, country:GB]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 22:51:58 -0000 Thanks guys! That was fast.... On 12/02/2019 20:13, Kristof Provost wrote: > On 2019-02-12 13:54:21 (-0600), Eric van Gyzen wrote: > > I see the same behavior on head (and stable/12). > > > > (kgdb) f > > #16 0xffffffff80ce5331 in ether_output_frame (ifp=0xfffff80003672800, > > m=0xfffff8000c88b100) at /usr/src/sys/net/if_ethersubr.c:468 > > 468 switch (pfil_run_hooks(V_link_pfil_head, &m, ifp, PFIL_OUT, > > > > 0xffffffff80ce5321 <+81>: mov %gs:0x0,%rax > > 0xffffffff80ce532a <+90>: mov 0x500(%rax),%rax > > => 0xffffffff80ce5331 <+97>: mov 0x28(%rax),%rax > > > > I think this is part of the V_link_pfil_head. I'm not very familiar > > with vnet. Does this need a CURVNET_SET(), maybe in garp_rexmit()? > > > Yes. I posted a proposed patch in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235699 > > Basically we get called through a timer, so there's no vnet context. It > needs to be set, and then we can safely use any V_ variables. > > Regards, > Kristof