From owner-freebsd-bugs  Sun Jan  7 15:40:23 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 82CFF37B402
	for <freebsd-bugs@hub.freebsd.org>; Sun,  7 Jan 2001 15:40:02 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f07Ne2V28153;
	Sun, 7 Jan 2001 15:40:02 -0800 (PST)
	(envelope-from gnats)
Received: from hobbes.melthusia.org (dt035n37.san.rr.com [24.30.140.55])
	by hub.freebsd.org (Postfix) with ESMTP id E810437B698
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Jan 2001 15:34:16 -0800 (PST)
Received: (from gordont@localhost)
	by hobbes.melthusia.org (8.11.1/8.11.1) id f07NYAA01394;
	Sun, 7 Jan 2001 15:34:10 -0800 (PST)
	(envelope-from gordont)
Message-Id: <200101072334.f07NYAA01394@hobbes.melthusia.org>
Date: Sun, 7 Jan 2001 15:34:10 -0800 (PST)
From: Gordon Tetlow <gordont@bluemtn.net>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/24136: Options tryDHCP and tryRTSOL in sysinstall's install.cfg confusing
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         24136
>Category:       bin
>Synopsis:       sysinstall's install.cfg tryRTSOL and tryDHCP don't work
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 07 15:40:02 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Gordon Tetlow
>Release:        FreeBSD 4.2-STABLE i386
>Organization:
Blue Mountain Arts
>Environment:

N/A

>Description:

When creating a install.cfg for an unattended installation, I specified
tryRTSOL=NO so it wouldn't prompt me for IPv6 configuration of my
network interfaces. Unfortunately, it still prompted me for it. From
looking at the code, tryDHCP=NO would produce the same result.

>How-To-Repeat:

Try an unattended install specifying tryRTSOL=NO. It will still prompt you
asking if you want to Configure IPv6 for your network interface.

>Fix:

Quick work around:
	Use tryRTSOL=ASDF or some other nonsensical value

Patch:
	I think this should do it. I wasn't able to rebuild it to check
	to see if it works, but the logic is there.

diff -uNr sysinstall.orig/install.c sysinstall/install.c
--- sysinstall.orig/install.c	Sun Jan  7 14:48:22 2001
+++ sysinstall/install.c	Sun Jan  7 14:48:52 2001
@@ -1060,8 +1060,8 @@
     variable_set2(VAR_TAPE_BLOCKSIZE,		DEFAULT_TAPE_BLOCKSIZE, 0);
     variable_set2(VAR_INSTALL_ROOT,		"/", 0);
     variable_set2(VAR_INSTALL_CFG,		"install.cfg", 0);
-    variable_set2(VAR_TRY_DHCP,			"NO", 0);	/* For now */
-    variable_set2(VAR_TRY_RTSOL,		"NO", 0);	/* For now */
+    variable_set2(VAR_TRY_DHCP,			"UNSET", 0);	/* For now */
+    variable_set2(VAR_TRY_RTSOL,		"UNSET", 0);	/* For now */
     cp = getenv("EDITOR");
     if (!cp)
 	cp = "/usr/bin/ee";
diff -uNr sysinstall.orig/tcpip.c sysinstall/tcpip.c
--- sysinstall.orig/tcpip.c	Sun Jan  7 14:48:22 2001
+++ sysinstall/tcpip.c	Sun Jan  7 14:50:02 2001
@@ -268,7 +268,7 @@
 
 	/* Try a RTSOL scan if such behavior is desired */
 	if (!variable_cmp(VAR_TRY_RTSOL, "YES") || 
-	    ((!variable_cmp(VAR_TRY_RTSOL, "NO")) && (!msgNoYes("Do you want to try IPv6 configuration of the interface?")))) {
+	    ((!variable_cmp(VAR_TRY_RTSOL, "UNSET")) && (!msgNoYes("Do you want to try IPv6 configuration of the interface?")))) {
 	    int i;
 	    int len;
 
@@ -294,7 +294,7 @@
 
 	/* First try a DHCP scan if such behavior is desired */
 	if (!variable_cmp(VAR_TRY_DHCP, "YES") || 
-	    ((!variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) {
+	    ((!variable_cmp(VAR_TRY_DHCP, "UNSET")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) {
 	    Mkdir("/var/db");
 	    Mkdir("/var/run");
 	    Mkdir("/tmp");

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message