From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 28 05:50:15 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F20FB16A44D for ; Tue, 28 Jun 2005 05:50:14 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C930243D5C for ; Tue, 28 Jun 2005 05:50:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j5S5oDBk024210 for ; Tue, 28 Jun 2005 05:50:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j5S5oDU1024209; Tue, 28 Jun 2005 05:50:13 GMT (envelope-from gnats) Resent-Date: Tue, 28 Jun 2005 05:50:13 GMT Resent-Message-Id: <200506280550.j5S5oDU1024209@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "David D.W. Downey" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEF0416A45D for ; Tue, 28 Jun 2005 05:45:54 +0000 (GMT) (envelope-from pgpkeys@pgpnet.us) Received: from www.pgpkeys.us (static-141-149-128-140.buff.east.verizon.net [141.149.128.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6917F43D49 for ; Tue, 28 Jun 2005 05:45:52 +0000 (GMT) (envelope-from pgpkeys@pgpnet.us) Received: from www.pgpkeys.us (pgpkeys@localhost [127.0.0.1]) by www.pgpkeys.us (8.13.3/8.13.3) with ESMTP id j5S5jq5o022269 for ; Tue, 28 Jun 2005 01:45:52 -0400 (EDT) (envelope-from pgpkeys@www.pgpkeys.us) Received: (from pgpkeys@localhost) by www.pgpkeys.us (8.13.3/8.13.3/Submit) id j5S5jp26022268; Tue, 28 Jun 2005 01:45:51 -0400 (EDT) (envelope-from pgpkeys) Message-Id: <200506280545.j5S5jp26022268@www.pgpkeys.us> Date: Tue, 28 Jun 2005 01:45:51 -0400 (EDT) From: "David D.W. Downey" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/82720: <[patch] Incorrect help output from growfs.c and mkfs.c> X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "David D.W. Downey" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2005 05:50:15 -0000 >Number: 82720 >Category: bin >Synopsis: <[patch] Incorrect help output from growfs.c and mkfs.c> >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 28 05:50:13 GMT 2005 >Closed-Date: >Last-Modified: >Originator: David D.W. Downey >Release: FreeBSD 5.4-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD www.pgpkeys.us 5.4-RELEASE-p1 FreeBSD 5.4-RELEASE-p1 #0: Sun Jun 26 08:14:43 EDT 2005 root@www.pgpkeys.us:/usr/obj/usr/src/sys/PGPNET i386 Duron 1.3GHz + 1GB DDR266 RAM >Description: newfs -N incorrectly states that, when passing superblocks for filesystem repair, fsck -b is the action for specifying the superblock to repair a filesystem as shown by the following output. OUTPUT ------- /dev/ad0s1a: 9000.0MB (18432000 sectors) block size 16384, fragment size 2048 using 49 cylinder groups of 183.77MB, 11761 blks, 23552 inodes. super-block backups (for fsck -b #) at: ----------- END OUTPUT The correct information is 'fsck_ffs -b #' for specifying this information. I have submitted 2 patches to repair the 2 files involved with displaying this incorrect information. The files involved are /usr/src/sbin/growfs/growfs.c and /usr/src/sbin/newfs/mkfs.c >How-To-Repeat: log in as uid 0 and run 'newfs -N /dev/' >Fix: Apply the patches below. Commit changes. --- growfs.c-062820050018 begins here --- --- growfs.c Thu Jul 29 07:28:24 2004 +++ growfs.c-fixed Tue Jun 28 00:17:48 2005 @@ -252,7 +252,7 @@ * Now build the cylinders group blocks and * then print out indices of cylinder groups. */ - printf("super-block backups (for fsck -b #) at:\n"); + printf("super-block backups (for fsck_ffs -b #) at:\n"); i = 0; width = charsperline(); --- growfs.c-062820050018 ends here --- --- mkfs.c-062820050021 begins here --- --- mkfs.c Tue Mar 1 00:30:30 2005 +++ mkfs.c-fixed Tue Jun 28 00:20:41 2005 @@ -477,7 +477,7 @@ * Now build the cylinders group blocks and * then print out indices of cylinder groups. */ - printf("super-block backups (for fsck -b #) at:\n"); + printf("super-block backups (for fsck_ffs -b #) at:\n"); i = 0; width = charsperline(); /* --- mkfs.c-062820050021 ends here --- >Release-Note: >Audit-Trail: >Unformatted: