From owner-svn-ports-head@FreeBSD.ORG  Thu Jan 30 19:39:58 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1BA04D6;
 Thu, 30 Jan 2014 19:39:58 +0000 (UTC)
Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116])
 by mx1.freebsd.org (Postfix) with ESMTP id C91991E60;
 Thu, 30 Jan 2014 19:39:57 +0000 (UTC)
Received: by smtp.kn-bremen.de (Postfix, from userid 10)
 id B75631E000C6; Thu, 30 Jan 2014 20:39:49 +0100 (CET)
Received: from enceladus10.kn-bremen.de (noident@localhost [127.0.0.1])
 by enceladus10.kn-bremen.de (8.14.5/8.14.5) with ESMTP id s0UJb3Zp069936;
 Thu, 30 Jan 2014 20:37:03 +0100 (CET)
 (envelope-from nox@enceladus10.kn-bremen.de)
Received: (from nox@localhost)
 by enceladus10.kn-bremen.de (8.14.5/8.14.5/Submit) id s0UJb3BL069935;
 Thu, 30 Jan 2014 20:37:03 +0100 (CET) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Thu, 30 Jan 2014 20:37:02 +0100
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r341790 - head/multimedia/szap-s2
Message-ID: <20140130193702.GA69785@enceladus10.kn-bremen.de>
References: <201401292244.s0TMib46086321@svn.freebsd.org>
 <33CFB80361C43DC17B99E87C@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <33CFB80361C43DC17B99E87C@atuin.in.mat.cc>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, Juergen Lock <nox@FreeBSD.org>,
 svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2014 19:39:58 -0000

On Wed, Jan 29, 2014 at 11:48:43PM +0100, Mathieu Arnold wrote:
> +--On 29 janvier 2014 22:44:37 +0000 Juergen Lock <nox@FreeBSD.org> wrote:
> | +
> | +.include <bsd.port.options.mk>
> |  
> |  do-install:
> |  	(cd ${WRKSRC} && ${INSTALL_PROGRAM} szap-s2 ${STAGEDIR}/${PREFIX}/bin)
> | -.if !defined(NOPORTDOCS)
> | -	${MKDIR} ${DOCSDIR}
> | -	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${DOCSDIR})
> | +.if ${PORT_OPTIONS:MDOCS}
> | +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> | +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> |  .endif
> 
> Hi,
> 
> Could you remove the include of port.options and always install the DOCS
> into the staging area ? It would save us parsing bsd.port.mk one time too
> many.
> 
> Like it says on https://wiki.freebsd.org/ports/StageDir
> 
> The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases
> when installed files are big enough to cause significant I/O overhead.
> 
Indeed, I should have remembered this...  Fixed.

 Thanx! :)
	Juergen