From owner-freebsd-current@FreeBSD.ORG Wed Jun 29 07:23:41 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8554C16A41C for ; Wed, 29 Jun 2005 07:23:41 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 636C743D48 for ; Wed, 29 Jun 2005 07:23:41 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5T7Nc7g028300; Wed, 29 Jun 2005 00:23:38 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5T7NcAx028299; Wed, 29 Jun 2005 00:23:38 -0700 Date: Wed, 29 Jun 2005 00:23:38 -0700 From: Brooks Davis To: Darren Pilgrim Message-ID: <20050629072338.GB24309@odin.ac.hmc.edu> References: <20050629053335.GA18808@odin.ac.hmc.edu> <001201c57c6e$fcb87140$0b2a15ac@SMILEY> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Yylu36WmvOXNoKYn" Content-Disposition: inline In-Reply-To: <001201c57c6e$fcb87140$0b2a15ac@SMILEY> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: current@freebsd.org Subject: Re: dhclient/wpa_supplicant patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2005 07:23:41 -0000 --Yylu36WmvOXNoKYn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2005 at 10:54:15PM -0700, Darren Pilgrim wrote: > From: Brooks Davis > >=20 > > --- rc.d/wpa_supplicant Tue Jun 28 22:24:18 2005 > > +++ rc.d/wpa_supplicant Tue Jun 28 18:51:32 2005 > <...> > > +if ! wpaif $ifn; then > > + return 1 > > +fi >=20 > I think it would be better if the dhcpif/wpaif test is contained within > netif. It has to exist in netif because its job is to determine how to > configure the interface. The dhclient and wpa_supplicant scripts should > be "dumb" single-task scripts to start/stop their respective clients. >=20 > By putting the dhcpif/wpaif test in the dhclient/wpa_supplicant scripts, > not only is it redundant, it makes it impossible to use the scripts > manually with an interface that isn't configured in /etc/rc.conf with > the DHCP or WPA magic words. Such manual operations are useful in > testing, temporary interfaces and custom profile-based configurations > where it's not possible/practical to have a configuration line in > /etc/rc.conf beforehand. Good point. The test is already in ifconfig_up/down so it's not needed in wpa_supplicant or dhclient. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Yylu36WmvOXNoKYn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCwkx5XY6L6fI4GtQRAgM+AKC4v4Gb3FGCeFkxLArI72bP4y9zQgCffaYp +f6C6E2tuc9j1lDBo9sn/84= =RtDl -----END PGP SIGNATURE----- --Yylu36WmvOXNoKYn--