Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Apr 2009 18:36:48 -0500
From:      "Rick C. Petty" <rick-freebsd2008@kiwi-computer.com>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        freebsd-hackers@FreeBSD.org
Subject:   Re: C99: Suggestions for style(9)
Message-ID:  <20090430233648.GA95360@keira.kiwi-computer.com>
In-Reply-To: <20090430.090226.1569754707.imp@bsdimp.com>
References:  <49F4070C.2000108@gmx.de> <20090428114754.GB89235@server.vk2pj.dyndns.org> <20090430.090226.1569754707.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 30, 2009 at 09:02:26AM -0600, M. Warner Losh wrote:
> 
> This is the biggest one, and I think it may be too soon.  Also, we
> need to be careful on the initialization side of things because we
> currently have a lot of code that looks like:
> 
> 
> 	struct foo *fp;
> 	struct bar *bp;
> 
> 	fp = get_foo();
> 	if (!fp) return;
> 	bp = fp->bp;
> 
> this can't easily be translated to the more natural:
> 
> 	struct foo *fp = get_foo();
> 	struct bar *bp = fp->bp;
> 
> since really you'd want to write:
> 
> 	struct foo *fp = get_foo();
> 	if (!fp) return;
> 	struct bar *bp = fp->bp;
> 
> which isn't legal in 'C'.

I thought we were talking about C99, in which case this is perfectly legal.
I certainly use it all the time in my C99 code.

And I thought this was the point of this discussion, to be able to declare
variables when you first use them.

-- Rick C. Petty



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090430233648.GA95360>