From nobody Tue Feb 3 10:08:40 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4zjB1mrYz6PJp8; Tue, 03 Feb 2026 10:09:02 +0000 (UTC) (envelope-from freebsd@seuros.com) Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4zj95vrkz3F56; Tue, 03 Feb 2026 10:09:01 +0000 (UTC) (envelope-from freebsd@seuros.com) Authentication-Results: mx1.freebsd.org; none Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id C19A9EC0096; Tue, 3 Feb 2026 05:09:00 -0500 (EST) Received: from phl-imap-04 ([10.202.2.82]) by phl-compute-06.internal (MEProxy); Tue, 03 Feb 2026 05:09:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seuros.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1770113340; x=1770199740; bh=HhsIrRE1rD ZRbcbcPOGY8cxP18eT7Nnm6+avoLzh0dk=; b=bAD1oeHyyCqsWkeuLsA3zUY+ZV EdlDR0xD2J0WLPquhuZSRQin9+mAwD+KQ6SLk04ilH4vvB8pdUCgSu8MJU6nJ7Ht UQB2q4AQSF/dIMCa9ShzBg0pZWtJngpOP/nsr6GhUU87GcV+1HdKZp7+mn0KbDLc hzcG6sz3NZgIkeTm5i4AYKB1Y7IIwqwd4mwgLPdt/HwAKbrXSmsdols0xrPZ0Nn7 1WCxaW5ozU7eblWg4wQcVlzOWRftjbZlbUUp2WEKH8zfV7FBtZDQPeiegzSZHBsJ 8F88eSIv5CyeWd2NRJdNeE0UbKgmNbj3xJTSJYrary6NINEi1H2kN7as3pmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1770113340; x=1770199740; bh=HhsIrRE1rDZRbcbcPOGY8cxP18eT7Nnm6+a voLzh0dk=; b=A0JmzPGyZO+YWIAKuwtMbwk2g/mYZYz5idNHnu22taWL7OyYntp i36Hb7ARc1/gQ0cEZGPDHJN8iTPjvBLGYwVDQGcbhbUaS1h2t010Bf+K6En0nGJW +LTtKAgslgtd3MayjR7uzBWkXCg1M9xuavaRpXxTgWOgZfzm0CYoHBWXz4qLbWji 1Rn69NlMOxb3qkueyfXansqEdzp3FJMGs5sH2QOM28K3nMHryg5zNIDu5+yIndsQ Ee+Oa7ztKzPbQnDTef9MapjnfvcIzK6b0BgVSPKsBsl74H8JYxWVQjBrOmOgNw/3 K6WMwDbaaf71cYXUeAOfK0goLdYvo/+K9bw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddujeelleeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgesrgdtreerredtjeenucfhrhhomhepfdetsgguvghl khgruggvrhcuuehouhguihhhfdcuoehfrhgvvggsshgusehsvghurhhoshdrtghomheqne cuggftrfgrthhtvghrnheptdetgeegudefjeehkeetleeugfekjeeftdeuheejgedvuefh leefudethfevheetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepfhhrvggvsghsugesshgvuhhrohhsrdgtohhmpdhnsggprhgtphhtthhopeei pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrughrihgrnhesfhhrvggvsghsug drohhrghdprhgtphhtthhopeguvghvqdgtohhmmhhithhsqdhsrhgtqdgrlhhlsehfrhgv vggsshgurdhorhhgpdhrtghpthhtohepuggvvhdqtghomhhmihhtshdqshhrtgdqmhgrih hnsehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepshhrtgdqtghomhhmihhtthgvrhhs sehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepkhhoshhtihhksggvlhesghhmrghilh drtghomhdprhgtphhtthhopeihrghnvghurhgrsggvhigrsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i0381466a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 92F12B6006E; Tue, 3 Feb 2026 05:09:00 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 X-ThreadId: Ak6CNxIQ9uwR Date: Tue, 03 Feb 2026 11:08:40 +0100 From: "Abdelkader Boudih" To: "Konstantin Belousov" , "Enji Cooper (yaneurabeya)" Cc: "Adrian Chadd" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> In-Reply-To: References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Content-Type: multipart/alternative; boundary=7d8754e56aed45bb9312875e66e5ee8a X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:151847, ipnet:103.168.172.0/24, country:AU] X-Rspamd-Queue-Id: 4f4zj95vrkz3F56 X-Spamd-Bar: ---- --7d8754e56aed45bb9312875e66e5ee8a Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I agree that this should not be permanent verbosity. The aim was not to add long-term noise, but to make the behavior observa= ble/greppable to reviewers while this logic is still being validated acr= oss a wide range of Apple models. I'm going to get few Apple devices to try on. Once we confirm that every= model behave the same, we could totally remove verbosity and treating i= t as assumed-working code. On Tue, 3 Feb 2026, at 08:56, Konstantin Belousov wrote: > On Mon, Feb 02, 2026 at 10:41:58PM -0800, Enji Cooper (yaneurabeya) wr= ote: > >=20 > > > On Feb 2, 2026, at 9:33=E2=80=AFPM, Konstantin Belousov wrote: > >=20 > > ... > >=20 > > >> + if (ACPI_SUCCESS(status)) { > > >> + device_printf(dev, > > >> + "Apple hardware: installed Darwin " > > >> + "OSI and removed other vendor OSI " > > >> + "(Windows, etc)\n"); > > > Why this verbosity is needed? > > >=20 > > > I see no benefit from it, other then consuming kernel memory. > >=20 > > I added the verbosity. It helped a few of us Apple users determine w= hether or not the functionality was working. I can trim down the verbosi= ty if needed in a followup commit. >=20 > Yes, I think that this verbosity is not warranted. If you want someth= ing > to be printed, much shorter messages would be enough. But I am not su= re > that any messaging is needed. >=20 --7d8754e56aed45bb9312875e66e5ee8a Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
I agree that this should not be pe= rmanent verbosity.

= The aim was not to add long-term noise, but to make the behavior observa= ble/greppable to reviewers while this logic is still being validated acr= oss a wide range of Apple models.

I'm going to get few Apple devices to try on. Once we confi= rm that every model behave the same, we could totally remove verbosity a= nd treating it as assumed-working code.


On Tue, 3 Feb = 2026, at 08:56, Konstantin Belousov wrote:
On Mon, Feb 02, 2026 at 10:41:58PM -0800, En= ji Cooper (yaneurabeya) wrote:
> 
> > = On Feb 2, 2026, at 9:33=E2=80=AFPM, Konstantin Belousov <kostikbel@gmail.com> wrote:
= > 
> ...
> 
> >&g= t; + if (ACPI_SUCCESS(status)) {
> >> + device_printf= (dev,
> >> +    "Apple hardware: insta= lled Darwin "
> >> +    "OSI and remov= ed other vendor OSI "
> >> +    "(Wind= ows, etc)\n");
> > Why this verbosity is needed?
> > 
> > I see no benefit from it, other t= hen consuming kernel memory.
> 
> I added= the verbosity. It helped a few of us Apple users determine whether or n= ot the functionality was working. I can trim down the verbosity if neede= d in a followup commit.

Yes, I think that this = verbosity is not warranted.  If you want something
to be = printed, much shorter messages would be enough.  But I am not sure<= /div>
that any messaging is needed.


--7d8754e56aed45bb9312875e66e5ee8a--