From owner-cvs-all@FreeBSD.ORG Mon May 21 19:48:58 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3BADB16A41F; Mon, 21 May 2007 19:48:58 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.freebsd.org (Postfix) with ESMTP id EE21313C448; Mon, 21 May 2007 19:48:57 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from niksun.com (anuket [10.70.0.5]) by anuket.mj.niksun.com (8.13.6/8.13.6) with ESMTP id l4LJmrBG064810; Mon, 21 May 2007 15:48:54 -0400 (EDT) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= Date: Mon, 21 May 2007 15:48:44 -0400 User-Agent: KMail/1.6.2 References: <200705211144.l4LBiEHY098477@repoman.freebsd.org> <200705211422.47842.jkim@FreeBSD.org> <86r6pagfic.fsf@dwp.des.no> In-Reply-To: <86r6pagfic.fsf@dwp.des.no> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <200705211548.46790.jkim@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Doug Barton , "Ralf S. Engelschall" , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostid X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2007 19:48:58 -0000 On Monday 21 May 2007 03:09 pm, Dag-Erling Smørgrav wrote: > Jung-uk Kim writes: > > Why don't we change smbios.system.uuid to all lower cases? ;-) > > I have no problem with that. > > For that matter, we could even verify that the UUID is valid within > the kernel before returning it to userland, eliminating the need > for a syntax check in etc/rc.d/hostid. 'smbios.system.uuid' is exported from loader, not from kernel. And it already checks two things, i.e., all zero's and all 0xff's, which are the most common and 'useless' UUIDs. If the SMBIOS has one of these, it is not set at all. Jung-uk Kim