From owner-cvs-all Mon Jan 13 6: 9:24 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8C7F37B401; Mon, 13 Jan 2003 06:09:23 -0800 (PST) Received: from mx0.freebsd-services.com (survey.codeburst.net [195.149.39.161]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49F2C43F13; Mon, 13 Jan 2003 06:09:23 -0800 (PST) (envelope-from paul@freebsd-services.com) Received: by mx0.freebsd-services.com (Postfix, from userid 1002) id 662051B208; Mon, 13 Jan 2003 14:09:22 +0000 (GMT) Date: Mon, 13 Jan 2003 14:09:22 +0000 From: Paul Richards To: Kelly Yancey Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw.c ipfw2.c Message-ID: <20030113140921.GH35226@survey.codeburst.net> References: <200212232008.gBNK8LAw041144@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200212232008.gBNK8LAw041144@repoman.freebsd.org> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Dec 23, 2002 at 12:08:21PM -0800, Kelly Yancey wrote: > kbyanc 2002/12/23 12:08:21 PST > > Modified files: > sbin/ipfw ipfw.8 ipfw.c ipfw2.c > Log: > Make preprocessor support more generic by passing all command-line options > after -p except for the last (the ruleset file to process) to the > preprocessor for interpretation. This allows command-line options besides > -U and -D to be passed to cpp(1) and m4(1) as well as making it easier to > use other preprocessors. I'm not sure this is a good idea. If you want to ensure that options are passed to the preprocessor then they can be put in quotes rather than changing normal command line semantics to make a certain option "magic" in that it swallows all remaining options except the last one. This will confuse anyone who doesn't read the documentation carefully and realises -p does this. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message