From owner-freebsd-current@FreeBSD.ORG Wed Oct 5 14:48:15 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D60D1106564A; Wed, 5 Oct 2011 14:48:15 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from sarah.protected-networks.net (sarah.protected-networks.net [IPv6:2001:470:1f07:4e1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 8F00B8FC0A; Wed, 5 Oct 2011 14:48:15 +0000 (UTC) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [202.12.127.84]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "Iain Butler", Issuer "RSA Class 2 Personal CA" (verified OK)) (Authenticated sender: imb@protected-networks.net) by sarah.protected-networks.net (Postfix) with ESMTPSA id 440BA616D; Wed, 5 Oct 2011 10:48:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1317826094; bh=puYoUFJ+Mf/bXRy8X/Z3yAbj3HKVflRZqIRAp7u/gTg=; h=Message-ID:Date:From:MIME-Version:To:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=lKmlaVhZA7KN8VwjoT6wXDrNCoCycgP2wVZiFbdJ8uuGbhvWnrDXUj02Lv21CO8Nn iJfQoH/yqZt3pfjMO2WDiJ3TP0lG2+C40oVlKEbkWNspGhSuIgqSLX0wmcQehPm DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:subject: references:in-reply-to:content-type:content-transfer-encoding; b=azRsiIXAadwkeA1KE6CgSc6CHr3HF45hp5J7MaRbqE7AP7L367QPKogO73E+VegDy +yt5kE3yj4ic5+T5S8zlSviB/K5dEm8RP5K9a4KOns5K4eIdAWtHWKPzLknzC+i Message-ID: <4E8C6E29.1010507@protected-networks.net> Date: Wed, 05 Oct 2011 10:48:09 -0400 From: Michael Butler User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 MIME-Version: 1.0 To: David Wolfskill , current@freebsd.org, Gabor Kovesdan References: <20111005135000.GE2831@albert.catwhisker.org> In-Reply-To: <20111005135000.GE2831@albert.catwhisker.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: Problem with r226035 - in head/usr.bin/grep: . regex? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2011 14:48:16 -0000 On 10/05/11 09:50, David Wolfskill wrote: > I noted the following after updating head to r226035: > ... >>>> stage 4.4: building everything > ... > cc -O2 -pipe -Dxregcomp=regcomp -Dxre_exec=re_exec -Dxregexec=regexec -Dxre_search=re_search -Dxre_compile_fastmap=re_compile_fastmap -Dxregerror=regerror -Dxre_comp=re_comp -Dxre_set_syntax=re_set_syntax -DHAVE_CONFIG_H -DRL_NO_COMPAT -DMI_OUT=1 -DTUI=1 -I. -I/usr/src/gnu/usr.bin/gdb/libgdb/../arch/i386 -I/usr/src/gnu/usr.bin/gdb/libgdb/../../binutils/libbfd -I/usr/src/gnu/usr.bin/gdb/libgdb/../../binutils/libbfd/i386 -I/usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/gdb/gdb -I/usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/gdb/gdb/config -I/usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/binutils/include -I/usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/gdb/include -I/usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/binutils/bfd -std=gnu99 -fstack-protector -c /usr/src/gnu/usr.bin/gdb/libgdb/../../../../contrib/gdb/gdb/tui/tui-source.c > cc1: warnings being treated as errors > /usr/src/usr.bin/grep/regex/tre-fastmatch.c: In function 'tre_match_fast': > /usr/src/usr.bin/grep/regex/tre-fastmatch.c:961: warning: comparison of unsigned expression< 0 is always false > *** Error code 1 > 1 error > *** Error code 2 > > [I'm sorry, but I won't be in position to test fixes until after my > laptop comes back from repair.] Does this look right? *** src/usr.bin/grep/regex/tre-fastmatch.c~ Wed Oct 5 07:25:39 2011 --- src/usr.bin/grep/regex/tre-fastmatch.c Wed Oct 5 09:02:39 2011 *************** *** 163,169 **** shift = bc; \ else \ { \ ! ts = ((long)u - v < 0) ? 0 : (u - v); \ shift = MAX(ts, bc); \ shift = MAX(shift, gs); \ if (shift == gs) \ --- 163,169 ---- shift = bc; \ else \ { \ ! ts = ((long)u - (long)v < 0) ? 0 : (u - v); \ shift = MAX(ts, bc); \ shift = MAX(shift, gs); \ if (shift == gs) \