From owner-freebsd-stable@freebsd.org Sat Apr 13 13:35:41 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85D331578BF7 for ; Sat, 13 Apr 2019 13:35:41 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D83D4842C5 for ; Sat, 13 Apr 2019 13:35:39 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id x3DDfjWf090153; Sat, 13 Apr 2019 06:41:45 -0700 (PDT) (envelope-from mckusick@mckusick.com) Message-Id: <201904131341.x3DDfjWf090153@chez.mckusick.com> From: Kirk McKusick To: Peter Holm Subject: Re: Replicable file-system corruption due to fsck/ufs cc: Jamie Landeg-Jones , jamie@catflap.dyslexicfish.net, Warner Losh , freebsd-stable@freebsd.org X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: <20190413123245.GA64592@x2.osted.lan> Comments: In-reply-to Peter Holm message dated "Sat, 13 Apr 2019 14:32:45 +0200." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90151.1555162905.1@chez.mckusick.com> Date: Sat, 13 Apr 2019 06:41:45 -0700 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: D83D4842C5 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [1.08 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.88)[0.882,0]; NEURAL_HAM_LONG(-0.75)[-0.755,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_SPAM_MEDIUM(0.22)[0.221,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: chez.mckusick.com]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.16)[ip: (-0.02), ipnet: 70.36.128.0/19(-0.01), asn: 46375(-0.71), country: US(-0.06)] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Apr 2019 13:35:41 -0000 > Date: Sat, 13 Apr 2019 14:32:45 +0200 > From: Peter Holm > To: Kirk McKusick > Cc: Jamie Landeg-Jones , jamie@catflap.dyslexicfish.net, > Warner Losh , freebsd-stable@freebsd.org > Subject: Re: Replicable file-system corruption due to fsck/ufs > > On Fri, Apr 12, 2019 at 04:13:00PM -0700, Kirk McKusick wrote: > >> This is indeed a bug in the calculation of the location of the last >> block of a file. I believe that the following patch to head will >> fix it. >> >> Peter, can you please test and let me know. >> >> If Peter confirms that it fixes the bug, I will check it into head >> and MFC it to 12-stable and 11-stable after a 2-week settle-in time. >> >> Kirk McKusick > > Yes, this patch works for me. > > -- > Peter Great, thanks for the quick test. Now committed to head as -r346185. Kirk