From owner-freebsd-hackers Mon Jun 5 21:40:25 1995 Return-Path: hackers-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id VAA26605 for hackers-outgoing; Mon, 5 Jun 1995 21:40:25 -0700 Received: from genesis.tiac.net (genesis.tiac.net [204.180.76.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id VAA26597 for ; Mon, 5 Jun 1995 21:40:22 -0700 Received: by genesis.tiac.net (8.6.9/genesis0.0) id AAA25972; Tue, 6 Jun 1995 00:40:18 -0400 Date: Tue, 6 Jun 1995 00:40:18 -0400 From: steve2@genesis.tiac.net (Steve Gerakines) Message-Id: <199506060440.AAA25972@genesis.tiac.net> To: hackers@freebsd.org Subject: Re: kernel page fault while doing tar to /dev/rft0 Sender: hackers-owner@freebsd.org Precedence: bulk > > >Fails my visial, this patch has been rejected for inclusion at this > > >point in time :-(. > > > > Patches should be reviewed by someone (if any :-) who is familiar with > > the code. > > Agreed, but it still fails on the fact the hunk is offset which means > the purson is not testing against -current code. Again, I could've retrieved -current fd.c and made the same patch in about 2 minutes (still can if you want), but since it's only one line moving I didn't bother. I was only trying to demonstrate what the offending line was. I'll speak in pseudo-patch next time, or perhaps say nothing since I'm apparently unqualified to contribute anything unless -current is on my machine anyhow. I'm not trying to break a release that's halfway out the door, just trying to point out where I think the problem is so someone on the inside can fix it. - Steve steve2@genesis.tiac.net