From owner-freebsd-current@FreeBSD.ORG Mon Nov 26 01:54:25 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 16988B6D; Mon, 26 Nov 2012 01:54:25 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9EFBA8FC12; Mon, 26 Nov 2012 01:54:24 +0000 (UTC) Received: by mail-vb0-f54.google.com with SMTP id l1so2861483vba.13 for ; Sun, 25 Nov 2012 17:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=EhjW/D1ueyGrA4wIkklHkbWMUOgdeIe30EQ5n1m0GzI=; b=kM7CCIQTYJanW1MXdM6WSe5MHIG2n6lo6zxomwA2JeiuNMC2QoFxdqQdo1jk6aVeMk oxYNK+vL/IVwTVxnCjquFPhTJkfLTTzTB1J2NEWHaTbtpt/8eqzHc78mGKmUBmPvsU7y z3Oj89T3+Yls7ytWC9Ul+w9273ZLh4mT/cJ8IURlPpptq1Y67I3jjpu/3vMpQtj5J7Up xkVe7VSNJdmXrItz3hzxdjTCh+3/RFawQYUpAkKOh+drD+lpMLMuA/lqcBrX9DmkldKH wXZUy6Mgc8WQDktEySvHrql7EpjqhCAKul4/oTnSU/nWZGcsoRZNoPU9LdqkV54UALMe esiA== Received: by 10.59.5.229 with SMTP id cp5mr17533943ved.32.1353894863726; Sun, 25 Nov 2012 17:54:23 -0800 (PST) Received: from mavbook.mavhome.dp.ua (cpe-67-244-107-195.nyc.res.rr.com. [67.244.107.195]) by mx.google.com with ESMTPS id cm9sm5162995vdb.3.2012.11.25.17.54.22 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 17:54:22 -0800 (PST) Sender: Alexander Motin Message-ID: <50B2CBCD.7090106@FreeBSD.org> Date: Mon, 26 Nov 2012 03:54:21 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120628 Thunderbird/13.0.1 MIME-Version: 1.0 To: mdf@FreeBSD.org Subject: Re: panic: sbuf_trim makes no sense on sbuf 0xffffff82434d8898 with drain References: <50B29B07.20808@daemonic.se> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Niclas Zeising , current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 01:54:25 -0000 On 26.11.2012 00:48, mdf@FreeBSD.org wrote: > On Sun, Nov 25, 2012 at 2:26 PM, Niclas Zeising > wrote: >> Hi! >> I consistently get this panic while trying to boot a kernel build from >> r243530. It happens when the entropy harvesting rc.d script starts. r243380 >> worked fine, I haven't tested any revisions in between. Attached is the >> backtrace from the kernel, as gotten by kgdb. The machine uses zfs as a >> root pool, and there have been churn in this area. To my untrained eyes, >> however, the issue seem related to hdaa.c. Please let me know if I can >> provide any more information. > > r243530 added the new sysctl that is causing panic. I'm not sure why > there's an sbuf_trim() call; there shouldn't be more than a few \n at > the end. IMO the sbuf_trim() can be eliminated. > > Alternately, the panic check can be removed and we could allow > sbuf_trim() to remove any un-emitted whitespace for an sbuf with > drain. > > CC'ing mav@ who introduced the code. (I introduced sbuf drains). Thanks. Removed. -- Alexander Motin