Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Nov 2001 20:57:21 -0800
From:      "Crist J. Clark" <cristjc@earthlink.net>
To:        Greg White <gregw-freebsd-stable@greg.cex.ca>
Cc:        freebsd-stable@FreeBSD.ORG
Subject:   Re: Update from 4.4-Stable from 4.3-Stable
Message-ID:  <20011101205721.D4360@blossom.cjclark.org>
In-Reply-To: <20011101201036.N58605@greg.cex.ca>; from gregw-freebsd-stable@greg.cex.ca on Thu, Nov 01, 2001 at 08:10:36PM -0800
References:  <5f.1d23fe2a.29136bca@aol.com> <20011101201036.N58605@greg.cex.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 01, 2001 at 08:10:36PM -0800, Greg White wrote:
> On Thu Nov 11/01/01, 2001 at 10:23:54PM -0500, Hunt127588@aol.com wrote:
> > I have upgraded to 4.4-Stable from 4.3-Stable. However, now my 
> > /usr/local/etc/rc.d/* scripts aren't started upon bootup. I have to manually 
> > start them to get these services started. I ran mergmaster and installed all 
> > files except /etc/rc.conf which I kept. I found the bad code and it is as 
> > follows (lines 678-717) in /etc/rc as of Nov 1st:
> > 
> > ###############################################
> > slist="${slist}${script_name_sep}${script}" 
> >                         done
> >                 fi
> >         done
> >         script_save_sep="$IFS"
> >         IFS="${script_name_sep}"
> >         for script in ${slist}; do
> >                 if [ -x "${script}" ]; then
> >                         (set -T
> >                         trap 'exit 1' 2
> >                         ${script} start)
> >                 fi
> >         done
> >         IFS="${script_save_sep}"
> > ###############################################
> 
> What's "bad" about that code? I have the same code in my /etc/rc, and
> /usr/local/etc/rc.d/*.sh services start just fine....Been tracking
> -STABLE on two boxes here since 4.1, no problems whatsoever. Do your
> scripts barf if given a 'start' argument or something? Wrong
> permissions? 

More likely, did the original poster run mergemaster(8)? If you do not
have "script_name_sep" set, the code above will break... maybe a catch
is in order?

Index: rc
===================================================================
RCS file: /export/ncvs/src/etc/rc,v
retrieving revision 1.286
diff -u -r1.286 rc
--- rc	2001/10/19 06:50:52	1.286
+++ rc	2001/11/02 04:55:29
@@ -813,6 +813,7 @@
 *)
 	echo -n 'Local package initialization:'
 	slist=""
+	: ${script_name_sep:=" "}
 	for dir in ${local_startup}; do
 		if [ -d "${dir}" ]; then
 			for script in ${dir}/*.sh; do

-- 
Crist J. Clark                     |     cjclark@alum.mit.edu
                                   |     cjclark@jhu.edu
http://people.freebsd.org/~cjc/    |     cjc@freebsd.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011101205721.D4360>