From owner-freebsd-current@freebsd.org  Mon Apr 19 13:12:32 2021
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4C0A05F1970
 for <freebsd-current@mailman.nyi.freebsd.org>;
 Mon, 19 Apr 2021 13:12:32 +0000 (UTC)
 (envelope-from freebsd-rwg@gndrsh.dnsmgr.net)
Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 4FP6g40ZdQz3v2G
 for <freebsd-current@freebsd.org>; Mon, 19 Apr 2021 13:12:32 +0000 (UTC)
 (envelope-from freebsd-rwg@gndrsh.dnsmgr.net)
Received: by mailman.nyi.freebsd.org (Postfix)
 id 13C1A5F1B1C; Mon, 19 Apr 2021 13:12:32 +0000 (UTC)
Delivered-To: current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1387C5F1D53
 for <current@mailman.nyi.freebsd.org>; Mon, 19 Apr 2021 13:12:32 +0000 (UTC)
 (envelope-from freebsd-rwg@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FP6g34qYGz3vNS;
 Mon, 19 Apr 2021 13:12:30 +0000 (UTC)
 (envelope-from freebsd-rwg@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 13JDCKvO066437;
 Mon, 19 Apr 2021 06:12:20 -0700 (PDT)
 (envelope-from freebsd-rwg@gndrsh.dnsmgr.net)
Received: (from freebsd-rwg@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 13JDCJO8066436;
 Mon, 19 Apr 2021 06:12:19 -0700 (PDT) (envelope-from freebsd-rwg)
From: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>
Message-Id: <202104191312.13JDCJO8066436@gndrsh.dnsmgr.net>
Subject: Re: sys/sys/param.h: 'main' instead of 'Master'?
In-Reply-To: <20210419072723.jd5jyys4go3rfwkv@aniel.nours.eu>
To: Baptiste Daroussin <bapt@nours.eu>
Date: Mon, 19 Apr 2021 06:12:19 -0700 (PDT)
CC: Ed Maste <emaste@freebsd.org>, Warner Losh <imp@bsdimp.com>,
 current <current@freebsd.org>
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 4FP6g34qYGz3vNS
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2021 13:12:32 -0000

> On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote:
> > On Fri, 16 Apr 2021 at 16:22, Warner Losh <imp@bsdimp.com> wrote:
> > >
> > > > > As well as "Origin".
> > > >
> > > > (Single) Source of Truth, maybe?
> > >
> > > s/Master, p/P/ also makes sense.
> > 
> > IMO instead of lightly rewording the existing comment we could just
> > remove it, it doesn't really add any clarity.
> > 
> > Instead we ought to add an introductory sentence or two to the block
> > comment above, explaining what __FreeBSD_version actually is.
> 
> fully agreed here! I had to explained many time what __FreeBSD_version actually
> was. A clear comment would be great ;)

Yes please!


-- 
Rod Grimes                                                 rgrimes@freebsd.org