From owner-freebsd-current Fri Jul 2 19:31:44 1999 Delivered-To: freebsd-current@freebsd.org Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (Postfix) with ESMTP id 86CD914CAF for ; Fri, 2 Jul 1999 19:31:36 -0700 (PDT) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.9.2/8.8.7) with ESMTP id WAA20132; Fri, 2 Jul 1999 22:31:34 -0400 (EDT) Date: Fri, 2 Jul 1999 22:31:34 -0400 (EDT) From: "Brian F. Feldman" X-Sender: green@janus.syracuse.net To: Matthew Jacob Cc: Greg Lehey , current@FreeBSD.ORG Subject: Re: Fixing other people's code (was: world broken in vinum (PATCH)) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 2 Jul 1999, Matthew Jacob wrote: > > On Friday, 2 July 1999 at 15:26:35 -0400, Brian F. Feldman wrote: > > > On Fri, 2 Jul 1999, Brian F. Feldman wrote: > > > > > >> Here's the fix. I'm sure it's not absolutely the same as what Greg will have, > > >> but if anyone wants to commit it, it will fix world. > > > > > > I know I _could_ commit it, but it's someone else's work that's being actively > > > maintained. It still does break world, but I don't think I have authority to > > > commit over Greg's work. I have NO idea what I meant by that wording. My change fixed the breakage in make world. > > > > I personally think that, in such a case, you'd be justified to commit > > it as a temporary measure. Due to the difference in time zones, this > > has hit people while I've been asleep. That doesn't mean the commit > > would stay, of course, but at least it would save people unnecessary > > pain. Note, of course, that I have now committed the correct file, > > which I had forgotten last night. > > > > What do you others think? > > opinion: > > If it's really blocking folks because things don't compile, it is always > acceptable to do what you need to do- the tree should always compile even > if -current. If the system doesn't boot because of change, then that's an > obvious one too. If things work differently or not as well, but things > are more or less working, it's not an emergency, so leave it for the > author to fix. > Sorry for the aforementioned REALLY messed-up language. Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___ green@FreeBSD.org _ __ ___ | _ ) __| \ FreeBSD: The Power to Serve! _ __ | _ \._ \ |) | http://www.FreeBSD.org/ _ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message