From owner-p4-projects@FreeBSD.ORG  Wed Feb  7 11:18:53 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 524E616A407; Wed,  7 Feb 2007 11:18:27 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DC33716A406
	for <perforce@freebsd.org>; Wed,  7 Feb 2007 11:18:25 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id CBBAC13C461
	for <perforce@freebsd.org>; Wed,  7 Feb 2007 11:18:25 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l17BIP9t047937
	for <perforce@freebsd.org>; Wed, 7 Feb 2007 11:18:25 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l17BIP96047925
	for perforce@freebsd.org; Wed, 7 Feb 2007 11:18:25 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Wed, 7 Feb 2007 11:18:25 GMT
Message-Id: <200702071118.l17BIP96047925@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 114167 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2007 11:18:54 -0000

http://perforce.freebsd.org/chv.cgi?CH=114167

Change 114167 by rwatson@rwatson_cinnamon on 2007/02/07 11:17:32

	Annotate an inter-thread race during bpf_setif.

Affected files ...

.. //depot/projects/zcopybpf/src/sys/net/bpf.c#16 edit

Differences ...

==== //depot/projects/zcopybpf/src/sys/net/bpf.c#16 (text+ko) ====

@@ -1407,6 +1407,9 @@
 	 * buffers by the time we get here.  If not, return an error.
 	 *
 	 * XXXRW: Could this be better abstracted?
+	 *
+	 * XXXRW: There are locking issues here with multi-threaded use: what
+	 * if two threads try to set the interface at once?
 	 */
 	switch (d->bd_bufmode) {
 	case BPF_BUFMODE_BUFFER: