From owner-p4-projects@FreeBSD.ORG Thu Dec 29 16:12:22 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id BD11916A423; Thu, 29 Dec 2005 16:12:21 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C8AB16A420 for ; Thu, 29 Dec 2005 16:12:21 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9ED1143D5E for ; Thu, 29 Dec 2005 16:12:07 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jBTGC3bv056397 for ; Thu, 29 Dec 2005 16:12:03 GMT (envelope-from jhb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jBTGC3Um056394 for perforce@freebsd.org; Thu, 29 Dec 2005 16:12:03 GMT (envelope-from jhb@freebsd.org) Date: Thu, 29 Dec 2005 16:12:03 GMT Message-Id: <200512291612.jBTGC3Um056394@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jhb@freebsd.org using -f From: John Baldwin To: Perforce Change Reviews Cc: Subject: PERFORCE change 88882 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2005 16:12:22 -0000 http://perforce.freebsd.org/chv.cgi?CH=88882 Change 88882 by jhb@jhb_slimer on 2005/12/29 16:11:02 WITNESS_SAVE/RESTORE doesn't work yet for spin locks. Affected files ... .. //depot/projects/smpng/sys/kern/kern_synch.c#94 edit Differences ... ==== //depot/projects/smpng/sys/kern/kern_synch.c#94 (text+ko) ==== @@ -251,7 +251,9 @@ struct thread *td; struct proc *p; int rval; +#if 0 WITNESS_SAVE_DECL(mtx); +#endif td = curthread; p = td->td_proc; @@ -277,7 +279,9 @@ DROP_GIANT(); mtx_assert(mtx, MA_OWNED | MA_NOTRECURSED); +#if 0 WITNESS_SAVE(&mtx->mtx_object, mtx); +#endif mtx_unlock_spin(mtx); /* @@ -319,7 +323,9 @@ #endif PICKUP_GIANT(); mtx_lock_spin(mtx); +#if 0 WITNESS_RESTORE(&mtx->mtx_object, mtx); +#endif return (rval); }