From owner-svn-src-head@freebsd.org Mon Jul 11 20:50:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E5B1B9292E for ; Mon, 11 Jul 2016 20:50:28 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC9B91E32 for ; Mon, 11 Jul 2016 20:50:27 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 18de9ab3-47a9-11e6-ac92-3142cfe117f2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.eu.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 11 Jul 2016 20:50:26 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u6BKoE5b004266; Mon, 11 Jul 2016 14:50:14 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1468270214.72182.126.camel@freebsd.org> Subject: Re: svn commit: r302592 - head/sys/arm/allwinner From: Ian Lepore To: Jared McNeill , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 11 Jul 2016 14:50:14 -0600 In-Reply-To: <201607112014.u6BKEpbH057588@repo.freebsd.org> References: <201607112014.u6BKEpbH057588@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 20:50:28 -0000 On Mon, 2016-07-11 at 20:14 +0000, Jared McNeill wrote: > Author: jmcneill > Date: Mon Jul 11 20:14:50 2016 > New Revision: 302592 > URL: https://svnweb.freebsd.org/changeset/base/302592 > > Log: > Return early from bus_dmamap_load callback if the error indicator > is set. > > Reviewed by: andrew, manu > > Modified: > head/sys/arm/allwinner/a10_mmc.c > > Modified: head/sys/arm/allwinner/a10_mmc.c > ===================================================================== > ========= > --- head/sys/arm/allwinner/a10_mmc.c Mon Jul 11 20:13:46 2016 > (r302591) > +++ head/sys/arm/allwinner/a10_mmc.c Mon Jul 11 20:14:50 2016 > (r302592) > @@ -364,6 +364,10 @@ a10_dma_cb(void *arg, bus_dma_segment_t > > sc = (struct a10_mmc_softc *)arg; > sc->a10_dma_map_err = err; > + > + if (err) > + return; > + > dma_desc = sc->a10_dma_desc; > /* Note nsegs is guaranteed to be zero if err is non-zero. > */ > for (i = 0; i < nsegs; i++) { > The comment about nsegs g'teed to be zero is now rather moot. That comment may have been copied from code I wrote long ago. I think the comment is true of the armv4/6 implementations, but it doesn't appear to be a g'tee made by the busdma manpage. -- Ian