From owner-svn-src-head@freebsd.org Tue Jan 17 03:57:52 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCC26CB307E; Tue, 17 Jan 2017 03:57:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89EE613A2; Tue, 17 Jan 2017 03:57:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x241.google.com with SMTP id 75so6834426pgf.3; Mon, 16 Jan 2017 19:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=fTjMo6ItsIoDuoOXxs5bAGC7achJEJ9OklVeMI0ejOA=; b=rO5fc0kE2kEiH7nQILAZWSF58dR0EC8pRCB58tNShz6/Uwal3+Pj911mOi1R7qqR9D ITrdLB1yberKp/aDHBIkYtKnadlVKY2VHtd9Tz7aDyocGF4+YM2Md53YCW92CLzRkBf/ qwSJzAQzrQ6DRj5RWWpo7UNiK4jEMhiRMF4u2emwC6KYKGGaQ+7hQvSzuf2t/1xPvLGR WcAJwpAZQ8KYPc0b3SbAwQ1haiPnFCjArgXelgHV/uURqJkeL9oDYwuMO7ZXmeINBB8t VJJBCKT3zHdCk9R+yi3giOp2Tz4BKDQF6qjjgiwoV7yBxXv3IRImlXRYyOLPAMYsV/be z8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=fTjMo6ItsIoDuoOXxs5bAGC7achJEJ9OklVeMI0ejOA=; b=Zn3j+3RlRnD845OZg4KG625R+nodNsGp4Hukgb3dpyK2e+jU4+qDNXju4g2Q4cGQJF w1B2Ri5Z96VL05eVA/cl/SlOBHOij6VXM6vd4u37nBBbKZMq+L0R4UkHnq5x+1mH/kaZ Rw67kp8caWPWudNV3jQSvf1I878SgoN2h5tQ44aGbIed/t5+UvfQ+Ys2Dk6i2JFrrD/c YPF6DzznvhX+tZT1bUMTtfowRSL55vRXz7jIl1Fp/QJsNgKTmNYTVSYALMcFpXpGB72h ZUzTV2zJIxQh+urnfFsbiiXDuXmdx6OvM12GQmUyJ6fDmccYY+5xkKw5pucNgsSwsuEK qSVg== X-Gm-Message-State: AIkVDXLzLzeG2qkfTuYQHYQmLtLdjC9zkZOENE6jtpwAy02ZFn4y5JLpyKAiBsI/qI5B1Q== X-Received: by 10.99.47.199 with SMTP id v190mr16673073pgv.26.1484625471988; Mon, 16 Jan 2017 19:57:51 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id s17sm51286122pgo.27.2017.01.16.19.57.51 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Jan 2017 19:57:51 -0800 (PST) Subject: Re: svn commit: r312331 - head/contrib/bsnmp/snmpd Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_91EC0E32-A2C3-46FD-9560-48973F51C376"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201701170352.v0H3qvNJ025187@repo.freebsd.org> Date: Mon, 16 Jan 2017 19:57:50 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <2C5D1730-6F2F-4D57-B977-420B0CFA81B1@gmail.com> References: <201701170352.v0H3qvNJ025187@repo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 03:57:52 -0000 --Apple-Mail=_91EC0E32-A2C3-46FD-9560-48973F51C376 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 16, 2017, at 19:52, Gleb Smirnoff wrote: >=20 > Author: glebius > Date: Tue Jan 17 03:52:57 2017 > New Revision: 312331 > URL: https://svnweb.freebsd.org/changeset/base/312331 >=20 > Log: > Fix regression from r310655, which broke operation of bsnmpd if it is = bound > to a non-wildcard address. As documented in ip(4), doing sendmsg(2) = with > IP_SENDSRCADDR on a socket that is bound to non-wildcard address is > completely different to using this control message on a wildcard one. >=20 > A fix is to add a bool to mark whether we did = setsockopt(IP_RECVDSTADDR) > on the socket, and use IP_SENDSRCADDR control message only if we did. >=20 > While here, garbage collect absolutely useless udp_recv() function = that > establishes some structures on stack to never use them later. I wasn=E2=80=99t aware of that =E2=80=94 thank you for fixing my = mistake (and I=E2=80=99ll add you to the next set of CRs here). udp_recv(..) was meant to provide a layer for doing the = necessary bits for IPv6.. I guess I=E2=80=99ll have to adjust (and hope = that the team doing it internally =E2=80=9Cgets it right=E2=80=9D). Cheers, -Ngie --Apple-Mail=_91EC0E32-A2C3-46FD-9560-48973F51C376 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYfZY+AAoJEPWDqSZpMIYVjSoQALZ4adbErShz4VYpa0wjF61Q krmDlBndAAKp3n6bfTCqfh+Yw+nhXhjjLffe40igpgr1y+EMfJktstkreNiGreXV ZO3G55b0iP7MpsQHfgTFDRKzuRP0yfkqin8w/5N4KMVxpZ7oPjC6DGKDfbFxTmc3 I1CftNo1SW9szQFgYw6ScPY+eZ8ECnrwUOnPUdC/IBH50N01amQeS44n1ZPGa2Ds ZpHC2R0XDGEtTQblmmOuFDVG/fKfCAyk5rrZVcv6d7J7ADivYgnYU/NnT6Low7l8 c2+J3TaBC7OuLOwPdJFGRYR6urWWLMDiMTEXFVoIRbotljqA8tPHsqbEB6mUt1AT GFhwQ10Nzf5y6635LX1P18wuKyFmiN/fdvWakKosvbM4k+DXxJJvjP4FhrOpgO/h +7UQ/MJiYcgK6MMAjM/KCyKlU4bZJz8O+3r0sPfZiC2VpQQvFH5FYUeSxTzHU7gf AZN7Tz6DjjNjHKDXgkWdz9bZZ9LsG61E7IuiEn6dI+oLoDBJi8SJz+rXuiNfshHm JUVzgpYmfZZh5HX5McW13PlPwlni9jKBebmPqpGYQOMaEskBFxaccT95vsam/QDi mQ850BvORbAK1jTSYnaJXtP9CdFODBgWS9OiNyYxPc4ZTDbLajfvjXISe4VjIZ9d ZT1c9EjvAl+2alk7k2a+ =cAcQ -----END PGP SIGNATURE----- --Apple-Mail=_91EC0E32-A2C3-46FD-9560-48973F51C376--