From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Mar 9 16:51:11 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 59BFEDAE for ; Mon, 9 Mar 2015 16:51:11 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 24A24384 for ; Mon, 9 Mar 2015 16:51:11 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t29GpBbI062477 for ; Mon, 9 Mar 2015 16:51:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198217] games/minecraft-server: avoid java-args.txt if DAEMON [PATCH] Date: Mon, 09 Mar 2015 16:51:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: freebsd@jonathanprice.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: flagtypes.name attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 16:51:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198217 Jonathan Price changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154091| |maintainer-approval+ Flags| | --- Comment #6 from Jonathan Price --- Created attachment 154091 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154091&action=edit Patch demonstrating radio options I apologise if I hadn't expressed my point clearly enough earlier. I have now produced a patch to demonstrate my thoughts. This patch removes the DAEMON option, and instead offers two radio options, STANDALONE and DAEMON. If you select STANDALONE, it installs java-args.txt and /usr/local/bin/minecraft-server. If you select DAEMON, it installs /usr/local/etc/rc.d/minecraft The issue I was having before, was that the DAEMON option was an additional option, rather than selecting daemon OR standalone, so technically speaking the DAEMON option should have given you the choice to run it as a daemon AND standalone, as you hadn't specified not to install the standalone files. Therefore, it would have caused confusing results for some users who didn't expect adding an option to remove files from the base install. If you have time, please give this patch a quick test and see if you can understand what I'm trying to say. I thank you for your continued time on this matter. -- You are receiving this mail because: You are the assignee for the bug.