From owner-freebsd-fs@freebsd.org Fri Oct 23 01:46:39 2020 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CC2AC4381F6 for ; Fri, 23 Oct 2020 01:46:39 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-to1can01on0600.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5d::600]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CHRsp1xqjz4jyD; Fri, 23 Oct 2020 01:46:37 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxwV78CoVzy/Q6tptPYsew4I9lbAU2In4RpbVfwIWI0kYn1eW4Fy8yd7bLMA6GCgaGJRGCI9Y27hsvw8utYRv4dZutduvqKSwGGgVeBklkxDbWn0Toab3qs948JpjIHrvT+UqHQ7Ad6wBnxMasH5wurEUunjz4OtZyTYB5DBur46H/379GiXJ64zSbsf2GNUG9JZHZFclXpOa1xEgVN++iIXbnqOPlWNgD50usUkGc0/tKscRU8bKdYU2O3Gu7NV/QRUcz7j9fNLXghKvIM/SR2xhDZD6DYKabzwqQu0Npy/7bm0/g4VwhMZLnL6uqCFfwB+VdPDiotnaz4Os/Hvew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OIAKqQJVhmeJrOrOVcZxcD1ODpi6VDShNdNjtXfxM/I=; b=ijAX+hOgG/s334BcqMdQgyvfTyV4HH6qNRoPIZ8m2iTe7UFQP/oN55xlj1nmevsLfNmUML0wPfxz5U0sj633S2w53kJaV+4ZWXYatfp5DJTJPFtXdGe1g9S/HTl3EZBGA8cfYWE5aZe4ILU2kqfgYx5ammPPJzDhGIdbsp8VwgPIq3Pj0VOgSS1xLaR53MrlysiVCBKn4q9vOHewn4ojJHx2dQ6r4XI/k6NEQhNcOL/n4UgNvf+aNz03FJPK0+cUAz/n8FNDlUSmvsCBBbjN5oK+4U+/gfA4Mf/uGj8QTvkU3bpeLWdXVVwb83EnqPa5Fd92njLuGdytw8TGiZJafA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OIAKqQJVhmeJrOrOVcZxcD1ODpi6VDShNdNjtXfxM/I=; b=D0xQJWY+OtUNqV5CEnMNkE3bzEDoOdQrFh4+qq7HaA4ugOY37XFQHsPGLmga/UkG2eLyMsKPclXhm0CAQ3c+KbkJ/hlQnEPYMbeONM+42PXXfuPNIClPw8yXWuy8kT7xJYu4kih6V00FV7sNHND+YcYQpRmOOwigSCQV9pfa+AzvOEU/QurpXLIvYbxv+QTDU1agfWEXYRJsDZ0n/f4di1cPMDizY8g7ME6AoedLwS6GBPqQJBlbZql4sioF3isY6IJAwMlYyiM0DPNnqo0N1xHayvX7brMeeMGFWSDLMj+DZok+ZvWwvanNnroJ9MC9y9CtHuqqcOlljQnbt6mxvQ== Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:24::27) by YTOPR0101MB0940.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:1c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Fri, 23 Oct 2020 01:46:32 +0000 Received: from YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20]) by YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM ([fe80::687f:d85a:a0a3:bd20%6]) with mapi id 15.20.3499.018; Fri, 23 Oct 2020 01:46:31 +0000 From: Rick Macklem To: Alan Somers , freebsd-fs Subject: Re: Always-0 NFS statistics Thread-Topic: Always-0 NFS statistics Thread-Index: AQHWqI5c7Rtqbk9vZkK4VD54JLlAUKmkZ5Vp Date: Fri, 23 Oct 2020 01:46:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b2e063b-be7e-4a01-82d2-08d876f577ab x-ms-traffictypediagnostic: YTOPR0101MB0940: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kdplgXg3v+8VcQhIfNtgS9eZt6ZeKjeORr9cfLYNAddneHCqR9xy5rYwuNiNhZ0Hs1epblSwWLFU0qwkCnsF/3tZDXZ4Jiasar2OjFZTf4neDfCKdLkBu3ReLTCFvFdnJFjTwscoDzEcbSonD9QfFPvecjvwitWv7WvVLKNwqYrfuFJ25mKesfS3UeH8mGQ4GnbPoJObunq34BgG0QmP8KUxGwqeDXLAJySV+QzBvtqPtdAvNH5mZze2UHuZO0o1fwIBJTg192WTg6+bYk4iDOR7HUUFh6YdHzjbHyI/IBOGfSN6pSQXMQUwAwN9mH4/FZe/3VCe3DR5SRp3smHp+EwqnRcTHN0Y7+oUTVqyWp2S4VyVZxcTHMr/4tWGn2OE5H77od36WcPN0xHJ59NKMA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(52536014)(66946007)(83380400001)(110136005)(66446008)(6506007)(66556008)(66476007)(76116006)(7696005)(91956017)(186003)(8676002)(86362001)(55016002)(2906002)(33656002)(5660300002)(8936002)(64756008)(71200400001)(966005)(450100002)(9686003)(498600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6jA9WN8yF7zqNh86OO6r4mSXul5vgmWcTbw3vU3gWCEGDcET2CmQAMZkYBDr4as8HI+LORUlwuLNRMiQpVQz9/e5Uw3L5j2b5oKaHbiCKZBST6uz7TrAq0dn9gg2xfi6sRMzjSSXSNHv2oJ8prCmgF2Zt/1FkVdJe2rxwjFQr3R+RZblfidSY6IzuMDyerwtBblcVaqjxy7Bi/DW2ZgM5EHQB19+VlVRZ4scgdGBfZAYtV5GQBceaDyf6rnLUaVCxqZmh2ZnndWvJjCp5CDUIVesoaotHM2CavRWE3hFDIkEUn7xGF9JEtIvOrpXmv33+UJhf5TsAZSkRMoULcOoo2R9arv5NASrUSGA2A2S0LcVrL0nFuMd+wMs4NeqgW+kl2pO2iLJDzfbptwjFUF6VZY0+hb0lG5uBL2BcNeNMc1oEGR3ysoZ7t2PyYXJHMlGVA9+DL4trO7e5yDtH+5Agj01cuVLZiKIBPEPBtzsFPTdYVWUasAt39/Mzpa+ZeNpG+P60L6Q0OQxsWW9nS8ESUON8rMr4EkdHSfIN5C+T2f1bCKhsRYRkt/vlEI6h2LrzL5owfJC/1fBzyzF/zxRdpkPdNRdbTIIGEoBS/2GdT8s6MW1yUYfzsIcnnKVpXb8RW8+NL/zzb5proQJ70PSYgedXmTRPGVtL55ADuFFpqBtp9mrCMTSJrfHgiJY2r2TziXqQ1i5Ar5kWyASK11daw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2e063b-be7e-4a01-82d2-08d876f577ab X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 01:46:31.8389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h6FVfPKXwG1kozgcQeBojbra6KxLOWc20f5hrCkdQe2kF3cEQPsd1zXnQbmRS9BcR/XHEKgZVtGhURCBqf1vkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB0940 X-Rspamd-Queue-Id: 4CHRsp1xqjz4jyD X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=D0xQJWY+; dmarc=pass (policy=none) header.from=uoguelph.ca; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 2a01:111:f400:fe5d::600 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-5.36 / 15.00]; NEURAL_HAM_MEDIUM(-0.98)[-0.984]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FREEFALL_USER(0.00)[rmacklem]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-0.995]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[uoguelph.ca:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[uoguelph.ca,none]; NEURAL_HAM_SHORT(-0.39)[-0.386]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 01:46:39 -0000 Alan Somers wrote:=0A= >It looks to me like three of the server statistics published by nfsstat ar= e=0A= >always 0. At least, cscope can't find any location in the kernel that set= s=0A= >these variables. Are they legitimately always zero in FreeBSD's=0A= >implementation of NFS, or are they reserved for future features, or is thi= s=0A= >a mistake? The stats are:=0A= >=0A= >nfsstat's name kernel name=0A= >Retfailed srv_errs=0A= >Faults srvrpc_errs=0A= >Idem srvcache_idemdonehits=0A= I believe these are left over from when the code was originally written=0A= for OpenBSD2.6, which did not have a separate kernel RPC, where the=0A= NFS code did the RPC calls.=0A= =0A= I suppose they should have been deleted from the FreeBSD port once=0A= it was incorporated into FreeBSD using the kernel RPC, but they were=0A= not.=0A= =0A= Revising the nfsstats structure yet again is a bother.=0A= I suppose you could modify nfsstats.c so that it never displays these=0A= fields. I doubt that would be considered a POLA violation.=0A= =0A= rick=0A= =0A= =0A= _______________________________________________=0A= freebsd-fs@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-fs=0A= To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"=0A= =0A=