Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Jul 2022 11:02:18 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7e936187afc9 - stable/12 - Adjust tdsaContext_t::NvmdResponseSet declaration to avoid clang 15 warning
Message-ID:  <202207241102.26OB2IQ7041361@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by dim:

URL: https://cgit.FreeBSD.org/src/commit/?id=7e936187afc90ee3590e33bf6a37fe6dd6446084

commit 7e936187afc90ee3590e33bf6a37fe6dd6446084
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2022-07-21 19:49:47 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2022-07-24 11:01:19 +0000

    Adjust tdsaContext_t::NvmdResponseSet declaration to avoid clang 15 warning
    
    With clang 15, the following -Werror warnings are produced:
    
        In file included from sys/dev/pms/freebsd/driver/ini/src/agtiapi.c:70:
        sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h:346:13: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
          volatile  NvmdResponseSet;
          ~~~~~~~~  ^
          int
    
    The NvmdResponseSet member is effectively only used as a boolean in the
    pms(4) driver, so it could be a single bit. But to avoid changing the
    semantics at all in this unmaintained driver, simply declare it as a
    volatile int.
    
    MFC after:      3 days
    
    (cherry picked from commit 95204d7a6368990e216db0ad51ef3e6018aed27c)
---
 sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h b/sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h
index 9f56775f06b8..ad62ac40997d 100644
--- a/sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h
+++ b/sys/dev/pms/RefTisa/tisa/sassata/common/tdsatypes.h
@@ -343,7 +343,7 @@ typedef struct tdsaContext_s {
   bit8   FatalErrorData[(5 * (1024 * 1024))];
 #endif /* TI_GETFOR_ONRESET */
   bit32	 sgpioResponseSet;    /*Used to sync between SGPIO Req and Resp */
-  volatile  NvmdResponseSet;
+  volatile int NvmdResponseSet;
 }  tdsaContext_t;
 
 #ifdef FAST_IO_TEST



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207241102.26OB2IQ7041361>