From owner-freebsd-current@FreeBSD.ORG Thu Feb 5 08:45:18 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3E06B641; Thu, 5 Feb 2015 08:45:18 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 2601C83F; Thu, 5 Feb 2015 08:45:17 +0000 (UTC) Received: from u10-2-32-011.office.norse-data.com (unknown [50.204.88.51]) by elvis.mu.org (Postfix) with ESMTPSA id F18DA341F912; Thu, 5 Feb 2015 00:45:15 -0800 (PST) Message-ID: <54D32DC3.6020409@mu.org> Date: Thu, 05 Feb 2015 00:45:55 -0800 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Konstantin Belousov , Dimitry Andric Subject: Re: Weird behavior writing to SSD on 2013 MacBook References: <54D2C3DA.4060205@freebsd.org> <54D319EA.5020709@freebsd.org> <20150205083035.GF42409@kib.kiev.ua> In-Reply-To: <20150205083035.GF42409@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Current , "Lundberg, Johannes" , Allan Jude X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2015 08:45:18 -0000 On 2/5/15 12:30 AM, Konstantin Belousov wrote: > On Thu, Feb 05, 2015 at 08:56:59AM +0100, Dimitry Andric wrote: >> If you let bsdtar continue, and press control-T a few times, does the >> user time (u) increase at all? Does it ever go any further, if you let >> it run for a very long time? >> >> I believe a problem may have been introduced by r277922, leading to >> filesystem hangs in some scenarios. It looks like this commit is also >> in dumbbell's github fork: >> >> https://github.com/dumbbell/freebsd/commit/83723416a6bb8695d60c6573722a81086899f521 >> > > Would be nice if you mailed me with your findings. > > Please try this. > > diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c > index 79783c8..700854e 100644 > --- a/sys/ufs/ffs/ffs_softdep.c > +++ b/sys/ufs/ffs/ffs_softdep.c > @@ -1393,7 +1393,7 @@ softdep_flush(addr) > VFSTOUFS(mp)->softdep_jblocks->jb_suspended)) > kthread_suspend_check(); > ACQUIRE_LOCK(ump); > - while ((ump->softdep_flags & (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) > + if ((ump->softdep_flags & (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) > msleep(&ump->softdep_flushtd, LOCK_PTR(ump), PVM, > "sdflush", hz / 2); > ump->softdep_flags &= ~FLUSH_CLEANUP; > @@ -1423,10 +1423,9 @@ worklist_speedup(mp) > > ump = VFSTOUFS(mp); > LOCK_OWNED(ump); > - if ((ump->softdep_flags & (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) { > + if ((ump->softdep_flags & (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) > ump->softdep_flags |= FLUSH_CLEANUP; > - wakeup(&ump->softdep_flushtd); > - } > + wakeup(&ump->softdep_flushtd); > } > > static int > @@ -1471,11 +1470,10 @@ softdep_speedup(ump) > TAILQ_INSERT_TAIL(&softdepmounts, sdp, sd_next); > FREE_GBLLOCK(&lk); > if ((altump->softdep_flags & > - (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) { > + (FLUSH_CLEANUP | FLUSH_EXIT)) == 0) > altump->softdep_flags |= FLUSH_CLEANUP; > - altump->um_softdep->sd_cleanups++; > - wakeup(&altump->softdep_flushtd); > - } > + altump->um_softdep->sd_cleanups++; > + wakeup(&altump->softdep_flushtd); > FREE_LOCK(altump); > } > } > _______________________________________________ Why the conversion of while() to if()? The reason for a while() when doing msleep/wakeup is typically to prevent superfluous wakeups from signalling early. -Alfred