From owner-freebsd-audit Thu Dec 14 15:35:50 2000 From owner-freebsd-audit@FreeBSD.ORG Thu Dec 14 15:35:48 2000 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id 9D2D437B402 for ; Thu, 14 Dec 2000 15:35:48 -0800 (PST) Received: from earth.causticlabs.com (oca-c1s5-22.mfi.net [209.26.94.207]) by peitho.fxp.org (Postfix) with ESMTP id 871D71360E; Thu, 14 Dec 2000 18:35:50 -0500 (EST) Received: by earth.causticlabs.com (Postfix, from userid 1000) id 1E6011F23; Thu, 14 Dec 2000 18:36:32 -0500 (EST) Date: Thu, 14 Dec 2000 18:36:31 -0500 From: Chris Faulhaber To: "Michael C . Wu" Cc: freebsd-audit@freebsd.org Subject: Re: libintl audit. Message-ID: <20001214183631.A30242@earth.causticlabs.com> Mail-Followup-To: Chris Faulhaber , "Michael C . Wu" , freebsd-audit@freebsd.org References: <20001213163638.A17119@peorth.iteration.net> <20001213180945.A79894@peitho.fxp.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001213180945.A79894@peitho.fxp.org>; from jedgar@fxp.org on Wed, Dec 13, 2000 at 06:09:45PM -0500 Sender: jedgar@earth.causticlabs.com Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Dec 13, 2000 at 06:09:45PM -0500, Chris Faulhaber wrote: > On Wed, Dec 13, 2000 at 04:36:38PM -0600, Michael C . Wu wrote: > > Hello guys, > > > > Will someone audit the attached tarball for me? :) > > > > So far: you should probably check the return values of strdup(3) calls. > > I will take a closer look at the code when I get a chance this evening :) > One other nit: --- gettext.c.orig Wed Dec 6 02:39:35 2000 +++ gettext.c Thu Dec 14 18:17:34 2000 @@ -336,7 +336,7 @@ } mohandle.addr = mmap(NULL, (size_t)st.st_size, PROT_READ, MAP_FILE | MAP_SHARED, fd, (off_t)0); - if (!mohandle.addr) { + if (mohandle.addr == MAP_FAILED) { close(fd); goto fail; } -- Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message