From owner-svn-src-head@freebsd.org Mon Apr 20 17:33:59 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F7A32A8CFC; Mon, 20 Apr 2020 17:33:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495Yhk6f6Nz3Dr7; Mon, 20 Apr 2020 17:33:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x432.google.com with SMTP id 18so1636066pfx.6; Mon, 20 Apr 2020 10:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=So9aQPMzKH0k8zIkaVyV1vGgfHh2te/EQqU77WbHhv0=; b=l5hekXjpXDWVi95jeHfj8VLqOz7DE5d7KhM3FdRZ1XNS+CUi7zeFdG51yCmu9XsS4l oiPmm+JlBBOhmAOP79qfKf3TS30Rx22AOiIlohWIuOvlJTCMX8791U7sC0OHsBc15Ky2 vwh/ib2d8PzLkrmWP18tOzpf3GWlK6x+ATjqWLcoMhC+RJNVT+u5aIfIVNZamFzspFyU Fr2S7GowzO1YaQE6cS0SwwOJO/PyKkXTsdWtn4uxpP/P7oCVrPArLbCjNzeEEvKfM+6L n44wR3B3iHfvSlRaguFF+lPXUbzz2iRHenUb5lQZON7OhYZtnAoqPBYtMBwj6NJ1RPHw J36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=So9aQPMzKH0k8zIkaVyV1vGgfHh2te/EQqU77WbHhv0=; b=sTSK1A5fGdXuaeEMoBDSdfnR+tZQTnLb18gqvznAasfH/CaDuRC0iYT6h6fOy70LGx kKHQqqDgsTGBB59Z+mPkiQjkKzSvT333i9NgQRoaeimRCuj714C35LA5U8Xbl6OJ9VV+ xvPXA21NW3LeEqcjwsZS9KxkmSMczUwwWZicNj9vDryK3ZvSm/nv4H8Q0CXMReRKYAqY CkeaXHpZJJVvkqP8D00zvIVAG3zakcSKju/jcanJR31PHvpcEEgg+K1D0HwTz0PzWw+B vrerch+VCJhgR//1aTOZZR8MgaseT4nKG88s08NaXM8YzheOG9WokQGiUPH0gOK+7s2L wN4g== X-Gm-Message-State: AGi0Pubajy2iSgEUZv71X55zcumAgcACaYY6SFtSeycgIHFWZSw5Pc+C 9cvBf8r35Rm43XMTTyy0FZG24YlEZEM= X-Google-Smtp-Source: APiQypI+okqfUQmTXofrNScEFpQhwL48CRgk3QDMWy5/+iS0jJFXvvjNrq7xN+uMeGp+XHSoRFkvJQ== X-Received: by 2002:aa7:962c:: with SMTP id r12mr18132675pfg.232.1587404037025; Mon, 20 Apr 2020 10:33:57 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 192sm63084pfu.182.2020.04.20.10.33.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 10:33:56 -0700 (PDT) From: Enji Cooper Message-Id: <1FC4B1BE-B147-466D-B01D-F4A670516FF1@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: svn commit: r360019 - head/tests/sys/kern Date: Mon, 20 Apr 2020 10:33:55 -0700 In-Reply-To: Cc: src-committers , svn-src-all , svn-src-head@freebsd.org To: "Jonathan T. Looney" References: <202004162007.03GK7Zgr089624@repo.freebsd.org> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Rspamd-Queue-Id: 495Yhk6f6Nz3Dr7 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 17:33:59 -0000 > On Apr 20, 2020, at 10:10 AM, Jonathan T. Looney = wrote: >=20 > On Sun, Apr 19, 2020 at 5:03 PM Enji Cooper > wrote: >=20 > > On Apr 16, 2020, at 1:07 PM, Jonathan T. Looney = wrote: > >=20 > > Author: jtl > > Date: Thu Apr 16 20:07:34 2020 > > New Revision: 360019 > > URL: https://svnweb.freebsd.org/changeset/base/360019 = > >=20 > > Log: > > Add a regression test for the changes in r359922 and r359923. > >=20 > > Note that the Python code has been tested on both Python 2.7 and = 3.7. > >=20 > > Reviewed by: olivier > > MFC after: 2 weeks > > Sponsored by: Netflix, Inc. >=20 > Ugh=E2=80=A6 I can tell by this commit that I just need to add = pytest support to kyua >_>=E2=80=A6 >=20 > I assume you're suggesting that we support running Python code = natively, instead of from a shell script. If so, I think that's a great = idea. >=20 > It looks like we're growing a number of Python scripts in the test = suite, and supporting them more natively is probably good for more than = one reason. That was exactly my thinking. The reason why I picked pytest is = that nose 1.x is abandoned, nose 2.x converges with pytest (and the page = recommends pytest), and raw unittest requires a lot of complexity. = Another plus of pytest is that it has an extensible plugin framework. It=E2=80=99s really unfortunate that we don=E2=80=99t have = better package integration in buildworld. It would make building and = installing tests a lot easier. Cheers, -Enji