From owner-svn-src-projects@freebsd.org Sat Mar 2 19:38:29 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09F87150C2D6 for ; Sat, 2 Mar 2019 19:38:29 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF8B777E69; Sat, 2 Mar 2019 19:38:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x433.google.com with SMTP id n125so544436pfn.5; Sat, 02 Mar 2019 11:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H/0RoJPqHB2K3nR77ew6skggltWE9wS3FhX+72cjHsM=; b=kAAEPrifsj41Q472WOZJDnFf5ycbF38DC8KHpNOwiaZ/MjJDoOIJW4DEgSypvN1p5L k5cnmDA0cz5UxMtatlswgxvFyTnxxI20D5lHnlislXTwwqewCLmJfHq8bTZnVBkZra6r UF5U5020NlzSbC7FtZAcO9Cahb9wrkdiAIXaEFPWRF0w8WZHXBo827qwOX4xpX1mUxCl jCCU8wY1FIoKYKTwJ+2i3wOO8/vHQqPC733kCU6ySFX2c8+Ri48/mit1GrWUKom9yaxy u9IuX3uyOo9NEshbhja44VVewlliwd0adRUhpVkUe54iHj8rrhlEex0FNgR8g1mBh+fo 3N0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H/0RoJPqHB2K3nR77ew6skggltWE9wS3FhX+72cjHsM=; b=i4uqdnY+GczggZH0GIeuOyjP90MMm3814MNn/DuBOEM1MkQxtuU2mUSUiU26VSBCoR FkzaK2gc2tIsAF2ghGAHxxh8J0g9ZkR7YVMq8+K8r9PtReXfzyF+zsKpM/g6yJEvvEv5 6b1qkVgqWyegYC6a1pvJHAcY7zNqz3S/sbTvMqnm8j5B6cDMYgQpLlXEmMXU4+aPearM 0x4ryG8j9ac5Quh+TkxcYXmPJovLm7dpBaE8OM9lhMFt8E/UfWpO+YrzmG9RD6LoVPxw 1GNFrr6iiFjDVGH3ZoEWUJmpzsyEzJCWO4E628UUA9G6i6sKAAejLD2G+dB5g4VTtEw6 GlmA== X-Gm-Message-State: APjAAAXG6BCXq97jySWcP8MFrMRxDI6cTTpL1qzUZl0hk53ZmL23wcCp o4Qe6HLJUdd/zbBoZdH4EZ6Rv35X X-Google-Smtp-Source: APXvYqxNUuhsB/y7W8khTUknX84p7MnddXFKpJKw9xesTrHjQ3G/KV1V9geHEKnjK9WFYYZ7rqJEpw== X-Received: by 2002:a65:64d9:: with SMTP id t25mr11129683pgv.244.1551555506472; Sat, 02 Mar 2019 11:38:26 -0800 (PST) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id q62sm3415488pfi.183.2019.03.02.11.38.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 11:38:25 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344727 - projects/fuse2/tests/sys/fs/fuse From: "Enji Cooper (yaneurabeya)" In-Reply-To: <201903021628.x22GSTTV073206@repo.freebsd.org> Date: Sat, 2 Mar 2019 11:38:24 -0800 Cc: src-committers , svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201903021628.x22GSTTV073206@repo.freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: EF8B777E69 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=kAAEPrif; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::433 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.92)[-0.919,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.58)[ip: (-8.04), ipnet: 2607:f8b0::/32(-2.72), asn: 15169(-2.04), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[3.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2019 19:38:29 -0000 > On Mar 2, 2019, at 08:28, Alan Somers wrote: >=20 > Author: asomers > Date: Sat Mar 2 16:28:29 2019 > New Revision: 344727 > URL: https://svnweb.freebsd.org/changeset/base/344727 >=20 > Log: > fuse(4) use a global environment check. >=20 > This is marginally faster than using an environment check in each = test case. > Also, if the global check fails then all of the tests are skipped. = Oddly, > it's not possible to skip a test in any other way. I used incorrect terminology in my previous description, so I want to = clarify my previous points. * SetupEnvironment(..) is for test programs [1]. * SetUp(..) [test fixture] is for test cases. All of these setup APIs have analogs, i.e., teardown APIs. In the next version of GoogleTest, they are adding an API called = `SetUpTestSuite(..)`, which will allow one to save state common in a = test suite, instead of having to do it per test case. The new API makes = sense for long running setup/teardown routines, like initializing a = database (which a test suite will use) or network server, from scratch. Cheers! -Enji 1. This API isn=E2=80=99t documented on GitHub; I=E2=80=99ll submit a PR = for it.=