From owner-freebsd-acpi@freebsd.org Fri Jun 26 14:47:40 2015 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F0DD498C66E for ; Fri, 26 Jun 2015 14:47:40 +0000 (UTC) (envelope-from Anthony.B.Jenkins@att.net) Received: from nm4-vm1.bullet.mail.ne1.yahoo.com (nm4-vm1.bullet.mail.ne1.yahoo.com [98.138.91.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B76EC10F9 for ; Fri, 26 Jun 2015 14:47:40 +0000 (UTC) (envelope-from Anthony.B.Jenkins@att.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1435329931; bh=8ziWJPJoNbOI+Sny0skZLM7XCwKbbXA+tufdT4W7lQ0=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=u9waclbDSI+XF7NeCUaa3UxN2RZ42NPb771BCUn3kwNWQnYCH1ZcBOa/gDfoNraOqNT2gsp7zgCK6S2OuvuK35QSH29A2GUtVKhTTPjbFyE42vGHV0mSNKVxYA0YrvJ8uiP2V2FBIPwgsgXVZLNJKlmSK5I0hBYIXQLReJkmlYM= Received: from [98.138.226.178] by nm4.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 14:45:31 -0000 Received: from [98.138.84.39] by tm13.bullet.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 14:45:31 -0000 Received: from [127.0.0.1] by smtp107.mail.ne1.yahoo.com with NNFMP; 26 Jun 2015 14:45:31 -0000 X-Yahoo-Newman-Id: 503766.89149.bm@smtp107.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: WHDG74YVM1kXhWwNJlQK0DKdGFoz7E_L6iWLuDnahU.WIyr 7DIdl_NyOOzC9DtNQ8sVaeAsS.lu2gsjmNzUOU4LWQGlqYUle41mRI7yML.X 9s0HQnfrqlE996Hiqebm6b4FsfdbSqub2epIiX8nUg87ZrEWz8XY1fgihqY5 wqLlSmOLT7wo.6iC.iTxhPfQEOK2KKon334YOLe2ifMLaFgcXETyiSE1_jEq 3JKinfnwYvqLnIig4c6v3fOLGOSqlQP8RAThPCPhOv624fJj9moh7mXLYqR3 1mYLlg3wLEmdV3rVjqQyMd0y3X1dE_5z3uFepFOJbbZDbc.B02X0uUG3c0zO b5F8Wg_5zlGFlLjKtpHtr69RkVl98DZbNDIoIoCKgSNx9DcinZsH4V8hRzf2 qa5m7uF.W9FBEH1inL1_a5_he_hAD7gof3_Bd6IbtdCHwnhvQfrMqqWARYTH prWp1hMtByTwmnxoAPVQbiBJcZSl.fNg77Xi49nnUx9MN5aQB66mw5eqlnKP gDXzt02aHD5Gnd_gHSHaCvkt6QuFWKkKzIyMCEtXIzTKYpfhMQwHVpg-- X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <558D658A.2080807@att.net> Date: Fri, 26 Jun 2015 10:45:30 -0400 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Moore, Robert" , Ian Smith , Warner Losh CC: "freebsd-acpi@freebsd.org" Subject: Re: [PATCH] ACPI CMOS region support rev. 6 References: <20150222180817.GD27984@strugglingcoder.info> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <20150317222704.K22641@sola.nimnet.asn.au> <550825DE.7030406@att.net> <56B494A3-2058-4B7B-8183-646A46753A53@bsdimp.com> <5509A282.6070207@att.net> <20150319184348.X22641@sola.nimnet.asn.au> <550ACAEC.3060808@att.net> <20150320002950.T22641@sola.nimnet.asn.au> <550AD9B7.4090508@att.net> <558CA785.1050904@att.net> <558CA7C9.9000304@att.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D30820A@ORSMSX112.amr.corp.intel.com> In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D30820A@ORSMSX112.amr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2015 14:47:41 -0000 On 06/25/2015 10:33 PM, Moore, Robert wrote: > How do you handle the fact that there are three different CMOS/RTC devices defined in the ACPI specification? (There are three different _HIDs). Right, each of the three CMOS/RTC devices in the ACPI spec has a different ACPI ID (PNP0B00, PNP0B01, PNP0B02). FreeBSD's CMOS RTC driver only attaches to PNP0B00; if a different CMOS device is present, there will be no CMOS/RTC driver (since we don't know how to talk to it). Should be a no-op, like for any unsupported device. If I had the specs for each of those devices, I could probably cobble together support for the other two, but that wasn't my original mission... Anthony > >> -----Original Message----- >> From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >> acpi@freebsd.org] On Behalf Of Anthony Jenkins >> Sent: Thursday, June 25, 2015 6:16 PM >> To: Ian Smith; Warner Losh >> Cc: freebsd-acpi@freebsd.org >> Subject: Re: [PATCH] ACPI CMOS region support rev. 6 >> >> ...and of course I forget the attachment... >> >> On 06/25/15 21:14, Anthony Jenkins wrote: >>> Sooo here's the new and improved rev. 6, "new and improved" because it >>> increases the diff line count by 332%. >>>> [ajenkins@ajenkins-hplaptop /usr/src]$ wc -l atrtc_c_rev5.diff >>>> atrtc_rev6.diff >>>> 220 atrtc_c_rev5.diff >>>> 731 atrtc_rev6.diff >>> This is to satisfy the request to split the atrtc.c driver into a "core" >>> part and "bus" parts: >>>> Looking at patch 5: >>>> >>>> You need to rework this so there's an atrtc_acpi.c. Put all the ACPI >> attachment in there. You should also split off the little bit that's ISA- >> specific into atrtc_isa. Once you do that, we can talk. >>>> Warner >>> I actually finished this patch a couple months ago and have been >>> running it on my laptop, I just don't see the point...maybe Warner >>> could elaborate on the rationale for his request? At the very least, >>> this should be two commits - the functional change and the >>> refactorization request. >>> >>> I may have also added Ian's request for verbosity tweaks, but it's >>> been a while... I don't see any CMOS logging noise FWIW. >>> >>> Thanks, >>> Anthony >>> >>> > _______________________________________________ > freebsd-acpi@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-acpi > To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"