Date: Fri, 26 Jun 2020 15:47:52 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540489 - in head/devel/fhist: . files Message-ID: <20200626134752.i4ygenf4cc6we6nk@aching.in.mat.cc> In-Reply-To: <20200626133811.GA60522@FreeBSD.org> References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> <20200626133811.GA60522@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4z2c7sfhdnt756g6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2020 at 01:38:11PM +0000, Alexey Dokuchaev wrote: > On Fri, Jun 26, 2020 at 03:28:41PM +0200, Mathieu Arnold wrote: > > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote: > > > ... > > > Please, "svn revert" patches which forwent no functional changes prior > > > to making commit. It just clutters the diff and decreases SNR. :-( > >=20 > > In that particular case, it was correct to commit the patch, it has > > functional change, the range information changed >=20 > I see only patch header change, and I'm pretty sure the old patch would > apply just fine (if by "range information" you mean the line address). >=20 > Generally, patch(1) does fuzzy application very well, which allows to > carry patches unmodified literally forever (until patched file changes > enough so the patch no longer applies). >=20 > If you were talking about something else, please be more specific. I was talking about the range information, yes, the line numbers. It is true that patch(1) does fuzzy patching, and it did when it applied that patch. The committer then checked that it was still building correctly, and ran makepatch to regenerate the patch. Now, the patches in the ports tree need to have a correct and coherent behavior, and fuzzy patching gets it wrong from time to time. This is why range information is not noise, but important metadata that we prefer to be correct all the time. --=20 Mathieu Arnold --4z2c7sfhdnt756g6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl71/IRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgLyuw/+NhpHo3I9TjGEC2pSnK03AbVjBR2vCmZC4nT3LaVwxhrqGTdJ5VmvJgMH 7dmnsWtPKiWueLZrfCy/w23XkUQf9rWEyjVwcl0Q0JlNmqNsmwiEX1RRhTdFHgmF w2dznd+9315P3d0eUrYwer9KT8J5oiWbM4bWJ+Xh1L8pI1iu6AFdlCUOPlQotE8x bCXL4R/Uu3n267n7/6cQr+h5Yxa/FtTjPGzKzk+mIN6FWEwvNfzycPo9FG8XClyQ vpZA71g1gU8eDEXA0fY6T70keOvrD/7f7gijcM//RNxiRePCqgrie2FNcOLgjxyS Wl17fLQ3BmT0slHeESxbOc6TWHQ9tOXEIJCWzDvM5NAhmGiULmH3vlFjyOhwLrVQ DqqNWjbGgDK3ENVx6HFzu80ER6DBtZGKN/5Oho5I1DC9IWYQ+DcMIAEu90covR4m Gq3omz2wOy2JSkU8ewuAD2feDX6fWoHvRCfHkfsnTBBKOeiEddkYf81EZdwh4qrS c6u7gQcwigZYil/on2G3YpC3MTKrHzCsugtAx7K4Pf+d+Ky/TZTFvgbW9SiuA5aX pJH87BcdsPJtaGnqTryggqy+tTy5R+o2awuNmc7x0/u/vKT6hMT1ckCV0JpnXG7j FTygb5nqQs4bDnYlbsvRMn8LzMvyLPiuJCSQ3oOTkFxHzypYNd0= =AQhW -----END PGP SIGNATURE----- --4z2c7sfhdnt756g6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200626134752.i4ygenf4cc6we6nk>