From owner-cvs-src@FreeBSD.ORG  Tue Nov 30 21:23:07 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A646416A4CE; Tue, 30 Nov 2004 21:23:07 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E6D3F43D46; Tue, 30 Nov 2004 21:23:06 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iAULMx3i056309;
	Tue, 30 Nov 2004 22:22:59 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: "M. Warner Losh" <imp@bsdimp.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 30 Nov 2004 14:21:11 MST."
             <20041130.142111.84752258.imp@bsdimp.com> 
Date: Tue, 30 Nov 2004 22:22:59 +0100
Message-ID: <56308.1101849779@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@freebsd.org
cc: DougB@dougbarton.net
cc: ru@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c
	src/sbin/mount_std mount_std.8 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Nov 2004 21:23:07 -0000

In message <20041130.142111.84752258.imp@bsdimp.com>, "M. Warner Losh" writes:
>In message: <54142.1101843659@critter.freebsd.dk>
>            "Poul-Henning Kamp" <phk@phk.freebsd.dk> writes:
>: Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.
>
>if ((mntopt & MNT_DEV) == MNT_DEV)
>
>fails.

As it should, that is not how you test a bitmap:

	if (mntopt & MNT_DEV)

works.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.