From owner-freebsd-bugs  Tue Nov 12 17:20: 7 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A5E8537B401
	for <freebsd-bugs@hub.freebsd.org>; Tue, 12 Nov 2002 17:20:05 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F069D43E77
	for <freebsd-bugs@hub.freebsd.org>; Tue, 12 Nov 2002 17:20:04 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gAD1K4x3026297
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 12 Nov 2002 17:20:04 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gAD1K4KN026296;
	Tue, 12 Nov 2002 17:20:04 -0800 (PST)
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D198537B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2002 17:19:52 -0800 (PST)
Received: from ground0.paix.net (ground0.paix.net [128.177.247.242])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7FF6E43E3B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Nov 2002 17:19:52 -0800 (PST)
	(envelope-from larson@eng.paix.net)
Received: (from larson@localhost) 
	by ground0.paix.net (8.9.3/8.9.1) id RAA35594; Tue, 12 Nov 2002 17:19:52 -0800 (PST)
	env-from (larson@eng.paix.net)
Message-Id: <200211130119.RAA35594@ground0.paix.net>
Date: Tue, 12 Nov 2002 17:19:52 -0800 (PST)
From: Alan Larson <larson@eng.paix.net>
Reply-To: larson@eng.paix.net
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.2
Subject: misc/45254: Sysinstall installs things it should not install, XF86 in my case.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         45254
>Category:       misc
>Synopsis:       Sysinstall installs things it should not install, XF86 in my case.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 12 17:20:04 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Alan Larson
>Release:        FreeBSD 4.6.2-RELEASE i386
>Organization:
PAIX.net
>Environment:

	4.6.2 install CD

>Description:

When you want to install almost everything, an obvious thing to try is to
click on "All", and then select the things you DON'T want to turn them off.

Doing this with XF86 doesn't work, since distSetEverything() turns on
    XF86Dists = DIST_XF86_ALL;
    XF86ServerDists = DIST_XF86_SERVER_ALL;
    XF86FontDists = DIST_XF86_FONTS_ALL;
but unsetting XF86 doesn't turn them off.


>How-To-Repeat:

Do system install, or Upgrade, select "All", then go down into custom
and unselect "XFree86 Distribution".  Watching the install, or looking
at the results, you see a bunch of it still got installed.


>Fix:
	
For now, as a work-around, note that the software is demented.  Later,
someone should clear all the XF86 stuff there when it is turned off.


While there, shortening the code needed to do an exclusive-OR in the
routine dmenuSetFlag() might inspire more confidence.


int
dmenuSetFlag(dialogMenuItem *tmp)
{
    if (*((unsigned int *)tmp->data) & tmp->aux)
        *((unsigned int *)tmp->data) &= ~tmp->aux;
    else
        *((unsigned int *)tmp->data) |= tmp->aux;
    return DITEM_SUCCESS;
}


int
dmenuSetFlag(dialogMenuItem *tmp)
{
    *((unsigned int *)tmp->data) ^= tmp->aux;	/* toggle bit on/off */
    return DITEM_SUCCESS;
}
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message