From owner-cvs-all Wed Aug 18 2:38:42 1999 Delivered-To: cvs-all@freebsd.org Received: from axl.noc.iafrica.com (axl.noc.iafrica.com [196.31.1.175]) by hub.freebsd.org (Postfix) with ESMTP id 0CE0D14DAB; Wed, 18 Aug 1999 02:38:26 -0700 (PDT) (envelope-from sheldonh@axl.noc.iafrica.com) Received: from sheldonh (helo=axl.noc.iafrica.com) by axl.noc.iafrica.com with local-esmtp (Exim 3.02 #1) id 11H28n-00047A-00; Wed, 18 Aug 1999 11:36:17 +0200 From: Sheldon Hearn To: Brian Feldman Cc: hackers@freebsd.org Subject: Re: cvs commit: src/bin/test test.c In-reply-to: Your message of "Tue, 17 Aug 1999 17:18:53 MST." <199908180018.RAA84904@freefall.freebsd.org> Date: Wed, 18 Aug 1999 11:35:57 +0200 Message-ID: <15808.934968957@axl.noc.iafrica.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk [Hi-jacked out of cvs-committers & cvs-all] On Tue, 17 Aug 1999 17:18:53 MST, Brian Feldman wrote: > green 1999/08/17 17:18:53 PDT > > Modified files: > bin/test test.c > Log: > The new test(1) did not use access() correctly. I don't know why, since > supposedly it's ksh-derived, and it's not broken in pdksh. I've added > a test for test running as root: if testing for -x, the file must be > mode & 0111 to get "success", rather than just existant. > > Reviewed by: chris What were you actually trying to fix, here? I didn't see any discussion of this on hackers, current or bugs, nor in response to my initial commit message. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message