From owner-freebsd-wireless@FreeBSD.ORG  Mon Jun 11 07:20:12 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C68C11065670
	for <freebsd-wireless@hub.freebsd.org>;
	Mon, 11 Jun 2012 07:20:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id B15CB8FC0A
	for <freebsd-wireless@hub.freebsd.org>;
	Mon, 11 Jun 2012 07:20:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5B7KCta004570
	for <freebsd-wireless@freefall.freebsd.org>;
	Mon, 11 Jun 2012 07:20:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5B7KCxj004569;
	Mon, 11 Jun 2012 07:20:12 GMT (envelope-from gnats)
Date: Mon, 11 Jun 2012 07:20:12 GMT
Message-Id: <201206110720.q5B7KCxj004569@freefall.freebsd.org>
To: freebsd-wireless@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/166190: commit references a PR
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2012 07:20:12 -0000

The following reply was made to PR kern/166190; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/166190: commit references a PR
Date: Mon, 11 Jun 2012 07:16:04 +0000 (UTC)

 Author: adrian
 Date: Mon Jun 11 07:15:48 2012
 New Revision: 236876
 URL: http://svn.freebsd.org/changeset/base/236876
 
 Log:
   Retried frames need to be inserted in the head of the list, not the tail.
   
   This is an unfortunate byproduct of how the routine is used - it's called
   with the head frame on the queue, but if the frame is failed, it's inserted
   into the tail of the queue.
   
   Because of this, the sequence numbers would get all shuffled around and
   the BAW would be bumped past this sequence number, that's now at the
   end of the software queue.  Then, whenever it's time for that frame
   to be transmitted, it'll be immediately outside of the BAW and TX will
   stall until the BAW catches up.
   
   It can also result in all kinds of weird duplicate BAW frames, leading
   to hilarious panics.
   
   PR:		kern/166190
 
 Modified:
   head/sys/dev/ath/if_ath_tx.c
 
 Modified: head/sys/dev/ath/if_ath_tx.c
 ==============================================================================
 --- head/sys/dev/ath/if_ath_tx.c	Mon Jun 11 07:11:34 2012	(r236875)
 +++ head/sys/dev/ath/if_ath_tx.c	Mon Jun 11 07:15:48 2012	(r236876)
 @@ -2309,7 +2309,7 @@ ath_tx_xmit_aggr(struct ath_softc *sc, s
  
  	/* paused? queue */
  	if (tid->paused) {
 -		ATH_TXQ_INSERT_TAIL(tid, bf, bf_list);
 +		ATH_TXQ_INSERT_HEAD(tid, bf, bf_list);
  		/* XXX don't sched - we're paused! */
  		return;
  	}
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"