From owner-cvs-all Thu Feb 25 21:34:43 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id E750D14EC2; Thu, 25 Feb 1999 21:34:32 -0800 (PST) (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by freefall.freebsd.org (8.9.2/8.9.2) id VAA69053; Thu, 25 Feb 1999 21:34:17 -0800 (PST) (envelope-from imp@FreeBSD.org) Message-Id: <199902260534.VAA69053@freefall.freebsd.org> From: Warner Losh Date: Thu, 25 Feb 1999 21:34:16 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/ufs/ufs ufs_vnops.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk imp 1999/02/25 21:34:16 PST Modified files: sys/ufs/ufs ufs_vnops.c Log: Fix last commit based on feedback from Guido, Bruce and Terry. Specifically, the test was in the wrong place, lacked a cast, didn't unlock the node, and exited to bad rather than abortit. Now we don't allow renaming of a file with LINK_MAX references. Move the test to earlier in the code as it is closer to where ip is obtained, as that is the style of the rest of the function. Didn't fix the problems bruce pointed out in the rename man page to include EMLINK, nor address his complaints about how the whole idea of incrementing the link count during a rename is potentially asking for trouble. Also didn't try to correct potential problem Terry pointed out with decrements not being similarly protected against underflow. Revision Changes Path 1.110 +6 -5 src/sys/ufs/ufs/ufs_vnops.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message