Date: Tue, 9 May 2023 09:40:07 -0400 From: Ed Maste <emaste@freebsd.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= <corvink@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024 Message-ID: <CAPyFy2D=n-OQ0kwVyY2t2aai9cwW88yMCXg65v7xGBcw_eGQRA@mail.gmail.com> In-Reply-To: <CAGudoHGU7538je-By68kLoQjzjbfJU6ZaRxR68xOwzPPWzAUNA@mail.gmail.com> References: <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> <692e003e4b684c093b16048a4e12cc2dd8fc1fe0.camel@FreeBSD.org> <CAGudoHGU7538je-By68kLoQjzjbfJU6ZaRxR68xOwzPPWzAUNA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > vmm kernel module and bhyve userland are sharing a cpuset_t. So, this > > commit introduces a mismatch in the ioctl signature of VM_RUN. Any > > advice how to fix this properly, would be appreciated. > > > > [1] > > https://github.com/freebsd/freebsd-src/blob/c543e09f1f8ef98f201f7dd3f34ae023d61dfa83/sys/amd64/include/vmm.h#L759 > > On one hand this really should not be a part of the abi (you could > have a pointer to cpuset and a a var stating the size). > > On the other hand, i suspect the least problematic long term solution > is to introduce usercpuset_t (or whatever the name) and have a > conversion func on import. This would still mean you need a kernel and > user variant of the vm_exit struct. Sorry about the breakage. I originally planned to bump both MAXCPU and cpuset_t size to 1024 in one commit, but split them in part to find unintended dependencies. I can revert the change for now and recommit it after one of the above is done.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2D=n-OQ0kwVyY2t2aai9cwW88yMCXg65v7xGBcw_eGQRA>