From owner-freebsd-current@FreeBSD.ORG  Tue Sep 16 08:02:21 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 105FC16A4B3; Tue, 16 Sep 2003 08:02:21 -0700 (PDT)
Received: from melusine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org
	[62.212.105.185])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 025D943FA3; Tue, 16 Sep 2003 08:02:20 -0700 (PDT)
	(envelope-from thomas@cuivre.fr.eu.org)
Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 1A0D12C3D0; Tue, 16 Sep 2003 17:02:19 +0200 (CEST)
Date: Tue, 16 Sep 2003 17:02:19 +0200
From: Thomas Quinot <thomas@cuivre.fr.eu.org>
To: deischen@freebsd.org
Message-ID: <20030916150218.GB62176@melusine.cuivre.fr.eu.org>
References: <20030916121916.GB47779@melusine.cuivre.fr.eu.org>
	<Pine.GSO.4.10.10309161044002.10005-100000@pcnet5.pcnet.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="aVD9QWMuhilNxW9f"
Content-Disposition: inline
In-Reply-To: <Pine.GSO.4.10.10309161044002.10005-100000@pcnet5.pcnet.com>
User-Agent: Mutt/1.4i
X-message-flag: WARNING! Using Outlook can damage your computer.
cc: Vladimir Kushnir <vkushnir@Alfacom.net>
cc: current@freebsd.org
Subject: Re: scsi_cd or atapicam crash in current.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Sep 2003 15:02:21 -0000


--aVD9QWMuhilNxW9f
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Le 2003-09-16, Daniel Eischen =E9crivait :

> I get this even without atapicam in the kernel.  Is trying
> CAMDEBUG and CAM_DEBUG_CDB going to show anything interesting?

No, indeed, probably not. Can you try the following patch:

Index: ata-lowlevel.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
retrieving revision 1.11
diff -u -r1.11 ata-lowlevel.c
--- ata-lowlevel.c	10 Sep 2003 09:57:16 -0000	1.11
+++ ata-lowlevel.c	16 Sep 2003 15:00:13 -0000
@@ -374,6 +374,11 @@
=20
     /* ATAPI PIO commands */
     case ATA_R_ATAPI:
+	if (request->status & (ATA_S_ERROR | ATA_S_DWF)) {
+	    request->error =3D ATA_IDX_INB(ch, ATA_ERROR);
+	    break;
+	}
+
 	length =3D ATA_IDX_INB(ch, ATA_CYL_LSB)|(ATA_IDX_INB(ch, ATA_CYL_MSB)<<8);
=20
 	switch ((ATA_IDX_INB(ch, ATA_IREASON) & (ATA_I_CMD | ATA_I_IN)) |
@@ -446,8 +451,6 @@
=20
 	case ATAPI_P_ABORT:
 	case ATAPI_P_DONE:
-	    if (request->status & (ATA_S_ERROR | ATA_S_DWF))
-		request->error =3D ATA_IDX_INB(ch, ATA_ERROR);
 	    break;
=20
 	default:
--=20
    Thomas.Quinot@Cuivre.FR.EU.ORG

--aVD9QWMuhilNxW9f
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQE/ZyX5AE1UuDk9JGkRAkxcAJ45smameys9W4gkXAY7ePz6H5gUewCfTE5C
UUyUTWQ0aDfsoRyaPJsY8fk=
=qD8I
-----END PGP SIGNATURE-----

--aVD9QWMuhilNxW9f--