From owner-svn-src-all@FreeBSD.ORG  Mon Mar 12 11:07:47 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E023210656D9;
	Mon, 12 Mar 2012 11:07:47 +0000 (UTC)
	(envelope-from stefan@fafoe.narf.at)
Received: from fep19.mx.upcmail.net (fep19.mx.upcmail.net [62.179.121.39])
	by mx1.freebsd.org (Postfix) with ESMTP id AC0308FC16;
	Mon, 12 Mar 2012 11:07:46 +0000 (UTC)
Received: from edge03.upcmail.net ([192.168.13.238]) by viefep19-int.chello.at
	(InterMail vM.8.01.05.04 201-2260-151-105-20111014) with ESMTP
	id <20120312110738.JOAW1220.viefep19-int.chello.at@edge03.upcmail.net>; 
	Mon, 12 Mar 2012 12:07:38 +0100
Received: from mole.fafoe.narf.at ([80.109.55.137])
	by edge03.upcmail.net with edge
	id kb7e1i00q2xdvHc03b7e4K; Mon, 12 Mar 2012 12:07:38 +0100
X-SourceIP: 80.109.55.137
Received: by mole.fafoe.narf.at (Postfix, from userid 1001)
	id 421B26D44A; Mon, 12 Mar 2012 12:07:38 +0100 (CET)
Date: Mon, 12 Mar 2012 12:07:38 +0100
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Dimitry Andric <dim@FreeBSD.org>
Message-ID: <20120312110737.GA1387@mole.fafoe.narf.at>
References: <201203121104.q2CB4mN2058832@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201203121104.q2CB4mN2058832@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r232857 - head/libexec/rtld-elf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Mar 2012 11:07:48 -0000

On Mon, Mar 12, 2012 at 11:04:48AM +0000, Dimitry Andric wrote:
> Modified: head/libexec/rtld-elf/rtld.c
> ==============================================================================
> --- head/libexec/rtld-elf/rtld.c	Mon Mar 12 10:36:03 2012	(r232856)
> +++ head/libexec/rtld-elf/rtld.c	Mon Mar 12 11:04:48 2012	(r232857)
> @@ -1895,7 +1895,7 @@ preinit_main(void)
>      int index;
>  
>      preinit_addr = (Elf_Addr *)obj_main->preinit_array;
> -    if (preinit_addr == (Elf_Addr)NULL)
> +    if (preinit_addr == (Elf_Addr *)NULL)
>  	return;
>  
>      for (index = 0; index < obj_main->preinit_array_num; index++) {
> @@ -2036,7 +2036,7 @@ objlist_call_init(Objlist *list, RtldLoc
>  	    call_initfini_pointer(elm->obj, elm->obj->init);
>  	}
>  	init_addr = (Elf_Addr *)elm->obj->init_array;
> -	if (init_addr != (Elf_Addr)NULL) {
> +	if (init_addr != (Elf_Addr *)NULL) {
>  	    for (index = 0; index < elm->obj->init_array_num; index++) {
>  		if (init_addr[index] != 0 && init_addr[index] != 1) {
>  		    dbg("calling init function for %s at %p", elm->obj->path,
> 

Why don't you simply remove the unnecessary casts?